Adding acceleration scaling factor#634
Adding acceleration scaling factor#634davetcoleman merged 3 commits intomoveit:indigo-develfrom BrettHemes-3M:indigo-devel
Conversation
|
I noticed I had a few naming issues in motion_planning_rviz_plugin_frame.ui that would generate warnings during the build process. These were corrected in commit 5a18d6e |
There was a problem hiding this comment.
Does this long name widen the UI too much? Screenshot?
There was a problem hiding this comment.
Oh, I just saw your screenshot.
If you change this to "Accel Scaling" does it reduce the required screen width? The MoveIt widget is already too wide IMHO so I'd prefer not to do something to make it even wider
There was a problem hiding this comment.
I agree with you and thing the whole widget is a bit big. As for the addition, I can do a side by side comparison but I am pretty sure that the widget width went unchanged.
There was a problem hiding this comment.
Before and after. No change in width but the widget did get one line taller (expected).
|
lgtm +1 |
|
Just a tiny comment: This is awesome. Looking forward to merge it (and maybe release?). |
|
@Hemes could you fix the merge conflicts? sorry about that. |
|
@davetcoleman ok, I got the conflicts fixed. In the process I had the same issue as last time where all of the commits that my fork was behind were added as commits to my fork. So I deleted the commit and got it working the second time but in the process seem to have messed up the commit history for the pull request. The final result is correct now. BTW is there a good reference or best practice for keeping up to date with upstream repositories? I set the original repo as the upstream remote but am unclear on the proper commands to update and get changes that have happened between the pull request and now (i.e., when to pull, merge, rebase, etc.). |
|
re:BTW - I maintain my indigo-devel to mirror the upstream version exactly, I never commit new stuff to that branch. Then I can just do |
Adding acceleration scaling factor
Extending changes in #547 to add acceleration scaling factor.
This adds support for setting a maximum acceleration scaling factor in the MotionPlanRequest msg, which can be used to scale the acceleration bounds in add_time_parametrization.
Includes necessary changes to
move_group
move_group_interface
Spinbox for motion planning rviz plugin
Requires other pulls requests in moveit_msgs and moveit_core which are stated below.