Skip to content
This repository was archived by the owner on Nov 13, 2017. It is now read-only.

Modifications for warehouse_ros refactor#607

Closed
TheBrewCrew wants to merge 1 commit intomoveit:jade-develfrom
TheBrewCrew:cbrew_warehouse_ros_refactor
Closed

Modifications for warehouse_ros refactor#607
TheBrewCrew wants to merge 1 commit intomoveit:jade-develfrom
TheBrewCrew:cbrew_warehouse_ros_refactor

Conversation

@TheBrewCrew
Copy link
Copy Markdown

This changes moveit_warehouse to be compatible with the refactor of warehouse_ros that I have done in moveit/warehouse_ros#22. This enables MoveIt! to be built on non LTS Ubuntu while allowing MongoDB to be dynamically loaded with pluginlib if warehouse_ros_mongo is installed.

@mikeferguson
Copy link
Copy Markdown
Contributor

@davetcoleman @130s -- once we get the new warehouse_ros released into j+k, we will need to get this into j+k as well

@130s
Copy link
Copy Markdown
Contributor

130s commented Jun 21, 2016

Ok. I briefly tried rebasing jade-devel to this branch and got multitude of conflicts that didn't seem easy to resolve. I'll have to try again with care but it'll be later this week if that's ok.

@130s 130s mentioned this pull request Jun 21, 2016
1 task
@davetcoleman
Copy link
Copy Markdown
Member

I just used this branch to get moveit compiling on Kinetic - I think its time to merge this long standing PR. However I found one compile-time bug - it seems a new file warehouse_services.cpp was added since you created this PR and so it does not initalize RobotStateStorage correctly. The fix is here. Could you take a look at that, and also rebase jade-devel onto this branch?

Thanks!

@mikeferguson
Copy link
Copy Markdown
Contributor

@davetcoleman -- Connor was an intern with us last summer -- I'm not sure he is really active on MoveIt at all right now -- so I would suggest that one of the maintainers do a cherry-pick/rebase/whatever to get a new PR open (as @130s did with Connor's other PR)

@davetcoleman
Copy link
Copy Markdown
Member

will do after my other PRs from today get merged

@davetcoleman
Copy link
Copy Markdown
Member

Superseded by #699

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants