Update Dockerfile on the humble branch to use ROS humble#644
Update Dockerfile on the humble branch to use ROS humble#644
Conversation
Signed-off-by: Ashton Larkin <ashton.larkin@picknik.ai>
Signed-off-by: Ashton Larkin <ashton.larkin@picknik.ai>
|
@MikeWrock So, it seems to me like the error stems from rolling code still being used somewhere. I tried modifying https://github.com/ros-planning/moveit2_tutorials/blob/adlarkin/humble_docker_version_fix/.github/workflows/docker-images.yml#L12 to only build humble and not rolling, but I am still seeing the same CI failures. It also looks like humble is used in the industrial_ci for this action (https://github.com/ros-planning/moveit2_tutorials/blob/adlarkin/humble_docker_version_fix/.github/workflows/ci.yaml), so I am not sure what is causing this issue at the moment. |
|
I am going to close this PR - it turns out that for the CI builds that build and push updated tutorial Docker images, the I have created an issue so that we can track the progress of getting the tutorial images fixed: #646 |
Description
The backport in e292e4d set the
ROS_DISTROtorollingfor thehumblebranch, which would probably cause issues for users who are trying to go through the MoveIt2 tutorials with MoveIt2 humble. This PR sets theROS_DISTROtohumblein the Dockerfile so that if users decide to use the Docker setup for the humble tutorials,ROS_DISTROmatches the MoveIt2 version.Checklist