Skip to content

[Servo] use the default launch file from the pkg#113

Merged
AndyZe merged 1 commit intomoveit:mainfrom
AndyZe:andyz/update_servo_launch_file
Oct 13, 2021
Merged

[Servo] use the default launch file from the pkg#113
AndyZe merged 1 commit intomoveit:mainfrom
AndyZe:andyz/update_servo_launch_file

Conversation

@AndyZe
Copy link
Copy Markdown
Member

@AndyZe AndyZe commented Sep 14, 2021 •
edited
Loading

This PR added a new example launch file. It is nice in that it shows how to launch Servo as a node component or as a standalone node.

So, now the tutorial can use that launch file and we can delete some of the launch files in this repo.

This launch file was not used anywhere AFAICT so I deleted it: servo_server_panda.launch.py

@facontidavide
Copy link
Copy Markdown
Contributor

facontidavide commented Sep 17, 2021 •
edited
Loading

In your branch I can see the file servo_cpp_interface_demo.launch.py but your instructions are:

ros2 launch moveit_servo servo_example.launch.py

Should that launch file remain there?

@facontidavide
Copy link
Copy Markdown
Contributor

facontidavide commented Sep 17, 2021

My concern with this is that it affects the MoveIt2 Foxy documentation and these particular changes were not ported to Foxy (main only).

Therefore:

  • Either we backport the changes merged in moveit_servo to Foxy
    or
  • we merge this PR to the version of ROS2 where moveit_ros/moveit_servo/launch/servo_example.launch.py can be found.

@AndyZe
Copy link
Copy Markdown
Member Author

AndyZe commented Sep 19, 2021

Thanks for the review @facontidavide! I'll get the ball rolling on backporting that PR to Foxy.

@AndyZe AndyZe force-pushed the andyz/update_servo_launch_file branch from a07c9d6 to 76b881e Compare October 13, 2021 17:26
@AndyZe
Copy link
Copy Markdown
Member Author

AndyZe commented Oct 13, 2021

@vatanaksoytezer @JafarAbdi it looks like we can merge this now since it will not affect Foxy. I would appreciate that to simplify launch file maintenance.

@tylerjw
Copy link
Copy Markdown
Member

tylerjw commented Oct 13, 2021

Thanks for the review @facontidavide! I'll get the ball rolling on backporting that PR to Foxy.

I don't think we should do that (we should resist changing foxy for moveit or the tutorials if it works as is). I do think this is a good change for main.

@AndyZe AndyZe merged commit b9ab7de into moveit:main Oct 13, 2021
@AndyZe AndyZe mentioned this pull request Oct 15, 2021
Merged
2 tasks
tylerjw pushed a commit that referenced this pull request Nov 10, 2021
@tylerjw
[Servo] use the default launch file from the pkg (#113)
6c23817
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tylerjw tylerjw tylerjw approved these changes

@JafarAbdi JafarAbdi Awaiting requested review from JafarAbdi

@vatanaksoytezer vatanaksoytezer Awaiting requested review from vatanaksoytezer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AndyZe @facontidavide @tylerjw