Skip to content

Rename ServoServer, update Readme#109

Merged
AndyZe merged 2 commits intomoveit:mainfrom
tylerjw:servo_component
Nov 2, 2021
Merged

Rename ServoServer, update Readme#109
AndyZe merged 2 commits intomoveit:mainfrom
tylerjw:servo_component

Conversation

@tylerjw
Copy link
Copy Markdown
Member

@tylerjw tylerjw commented Aug 30, 2021

Description

Tutorial change to go with this PR: moveit/moveit2#649

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@tylerjw tylerjw requested a review from AndyZe August 30, 2021 23:14
@tylerjw tylerjw mentioned this pull request Aug 30, 2021
Merged
4 tasks
@tylerjw tylerjw mentioned this pull request Oct 4, 2021
Merged
2 tasks
AndyZe
AndyZe reviewed Oct 4, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@AndyZe AndyZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to encounter the same problem that PR #113 did -- this will target the Foxy branch, but the PR you've made in moveit2 targets Rolling.

I guess it is time to create a Foxy branch for the tutorials so we can merge this PR and #113 to Rolling.

@AndyZe
Copy link
Copy Markdown
Member

AndyZe commented Oct 14, 2021

Needs a rebase then I'll test it. LGTM at this point

@tylerjw tylerjw changed the title Rename ServoServer to ServoComponent Rename ServoServer to ServoNode Oct 14, 2021
AndyZe
AndyZe requested changes Oct 15, 2021
View reviewed changes
@AndyZe AndyZe mentioned this pull request Nov 2, 2021
Closed
2 tasks
@AndyZe
Copy link
Copy Markdown
Member

AndyZe commented Nov 2, 2021

I went ahead and addressed my own feedback and updated the Readme, too. LGTM now

@AndyZe AndyZe changed the title Rename ServoServer to ServoNode Rename ServoServer, update Readme Nov 2, 2021
@AndyZe AndyZe merged commit 5f43e49 into moveit:main Nov 2, 2021
@AndyZe AndyZe mentioned this pull request Nov 2, 2021
Closed
@tylerjw tylerjw deleted the servo_component branch November 2, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyZe AndyZe AndyZe approved these changes

@JafarAbdi JafarAbdi JafarAbdi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tylerjw @AndyZe @JafarAbdi