Configure Travis#57
Conversation
|
In your PR description, please add more detail about what you did i.e. "ran clang-format on whole codebase" better: put clang-formatting in different PR |
| - CXXFLAGS="-Wall -Wextra -Wwrite-strings -Wunreachable-code -Wpointer-arith -Wredundant-decls -Wno-unused-parameter -Wno-unused-but-set-parameter -Wno-unused-function" | ||
| - WARNINGS_OK=false | ||
| matrix: | ||
| - TEST="clang-format catkin_lint" |
There was a problem hiding this comment.
@rhaschke added an ament_lint, let's keep that enabled or at least commented out with TODO so we remember to add it later
| - WARNINGS_OK=false | ||
| matrix: | ||
| - TEST="clang-format catkin_lint" | ||
| - TEST=clang-tidy-fix |
There was a problem hiding this comment.
add TODO to re-enable in future
| - compiler: clang | ||
| env: ROS_REPO=ros-shadow-fixed | ||
| BEFORE_DOCKER_SCRIPT="source moveit_kinematics/test/test_ikfast_plugins.sh" | ||
| CXXFLAGS="-Wall -Wextra -Wwrite-strings -Wunreachable-code -Wpointer-arith -Wredundant-decls -Wno-unused-parameter -Wno-unused-function -Wno-overloaded-virtual" |
There was a problem hiding this comment.
This is some pretty fancy ikfast testing stuff @rhaschke did, at least comment out with TODO to re-instate when ready
There was a problem hiding this comment.
I believe @rhaschke was the one who first suggested we remove it here. We always have the moveit repo to go back to for examples.
There was a problem hiding this comment.
There is no reason to remove this. It should compile for MoveIt2 as well, shouldn't it?
There was a problem hiding this comment.
Restored for now. If it doesn't pass I'll comment out with a todo
There was a problem hiding this comment.
panda_ikfast_plugin: Cannot locate rosdep definition for [eigen_conversions]
There was a problem hiding this comment.
If you already figured out that eigen_conversions is not available in ROS2 anymore, why not directly replace it with some tf2 equivalents?
|
Right now, Travis just tests that 3rd-party dependencies in the ROS_WS compile. |
| # This config file for Travis CI utilizes https://github.com/ros-planning/moveit_ci/ package. | ||
| sudo: required | ||
| dist: xenial # distro used by Travis, moveit_ci uses the docker image's distro | ||
| dist: trusty # distro used by Travis, moveit_ci uses the docker image's distro |
There was a problem hiding this comment.
Why should Travis tun on trusty? Shouldn't we use bionic?
There was a problem hiding this comment.
Travis only provides two distributions: trusty and xenial (and the latter was only added relatively recently).
The dist here is not necessarily where code is actually build: as long as Docker is available, you could use whatever version of Ubuntu.
There was a problem hiding this comment.
I even added an in-line comment for this, above! I guess it's not clear enough.
#77
…y_action Port execute_trajectory_action to ROS2
* adding changes to move_group.launch * very minor fixup to chomp
… Some typos. (moveit#209) In some places it does not make sense to replace the pr2 with the panda arm because the panda arm is fixed to the environment (see line moveit#57) and does not have a left and a right arm (see line moveit#81). I would suggest replacing panda with a mobile robot (e.g. the pr2) in line moveit#57 and using less specific termes like left_arm and right_arm in line moveit#81. Also, there were two typos that ocurred to me when reading the tutorial.
Description
This pr attempts to make the necessary changes to get the master branch to pass travis.
It depends on #56 and #46
Checklist