Skip to content

Update move_group_launch_test_common.py to use projection_evaluator#470

Merged
henningkayser merged 3 commits intomainfrom
JafarAbdi-patch-1
May 20, 2021
Merged

Update move_group_launch_test_common.py to use projection_evaluator#470
henningkayser merged 3 commits intomainfrom
JafarAbdi-patch-1

Conversation

@JafarAbdi
Copy link
Copy Markdown
Member

Description

As shown in the setup for the new OMPL constrained state space

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@JafarAbdi JafarAbdi requested a review from henningkayser May 20, 2021 16:07
Copy link
Copy Markdown
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Should this be part of moveit_resources?

Copy link
Copy Markdown
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JafarAbdi that doesn't fix it yet

@henningkayser
Copy link
Copy Markdown
Member

@JafarAbdi that doesn't fix it yet

Actually, it does! But there was an upstream change in ros2_controllers that broke CI as well. Here is the fix for that moveit/moveit_resources#74. I'll merge this since the fix is trivial and I confirmed this to be working locally.

henningkayser
henningkayser approved these changes May 20, 2021
@henningkayser henningkayser merged commit aad154f into main May 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the JafarAbdi-patch-1 branch May 20, 2021 20:44
MikeWrock pushed a commit to MikeWrock/moveit2 that referenced this pull request Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants