Skip to content

Add forward_trajectory local solver plugin#359

Merged
henningkayser merged 1 commit intomoveit:feature/hybrid_planningfrom
sjahr:pr-add_forward_trajectory_plugin
Mar 25, 2021
Merged

Add forward_trajectory local solver plugin#359
henningkayser merged 1 commit intomoveit:feature/hybrid_planningfrom
sjahr:pr-add_forward_trajectory_plugin

Conversation

@sjahr
Copy link
Copy Markdown
Contributor

@sjahr sjahr commented Feb 8, 2021

Description

This PR adds a local solver plugin to the hybrid planning architecture, that simply forwards the local solution trajectory-point-wise to the underlying controller.

Checklist

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 8, 2021

Codecov Report

Merging #359 (b6e76f5) into feature/hybrid_planning (f33df4b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                   Coverage Diff                    @@
##           feature/hybrid_planning     #359   +/-   ##
========================================================
  Coverage                    48.00%   48.00%           
========================================================
  Files                          157      157           
  Lines                        14843    14843           
========================================================
  Hits                          7124     7124           
  Misses                        7719     7719           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f33df4b...378b7dc. Read the comment docs.

@sjahr
Copy link
Copy Markdown
Contributor Author

sjahr commented Mar 10, 2021

@henningkayser Seems like a failing moveit_servo test leads to not passing the CI checks. Is that a flaky test? Would rebasing the PR and the feature branch solve the issue?

@henningkayser
Copy link
Copy Markdown
Member

@henningkayser Seems like a failing moveit_servo test leads to not passing the CI checks. Is that a flaky test? Would rebasing the PR and the feature branch solve the issue?

Sorry, I somehow didn't notice this. I'll merge your PR and after that you could prepare a rebased feature branch that we can force-push. I'm not sure if the servo issue would be resolved by that though.

@henningkayser henningkayser merged commit 646770e into moveit:feature/hybrid_planning Mar 25, 2021
@tylerjw
Copy link
Copy Markdown
Member

tylerjw commented Mar 25, 2021

@sjahr the failing servo test is flaky. My migration to GitHub Actions PR disables it until we can figure out how to fix it.

@sjahr sjahr deleted the pr-add_forward_trajectory_plugin branch April 16, 2021 19:35
sjahr added a commit to sjahr/moveit2 that referenced this pull request Apr 16, 2021
sjahr added a commit to sjahr/moveit2 that referenced this pull request May 4, 2021
sjahr added a commit to sjahr/moveit2 that referenced this pull request May 4, 2021
sjahr added a commit to sjahr/moveit2 that referenced this pull request May 9, 2021
sjahr added a commit to sjahr/moveit2 that referenced this pull request Jun 4, 2021
Use ros2_control based joint simulation and remove unnecessary comment

Update copyrights

Restructure hybrid planning package

Fix formatting and add missing time stamp in local solver plugin

Remove unnecessary logging and param loading

Enable different interfaces between local planner and controller

Use JointGroupPositionController as demo hardware controller
sjahr added a commit to sjahr/moveit2 that referenced this pull request Jun 7, 2021
* Add forward_trajectory local solver plugin (moveit#359)
* Use ros2_control based joint simulation and remove unnecessary comment
* Update copyrights
* Restructure hybrid planning package
* Fix formatting and add missing time stamp in local solver plugin
* Remove unnecessary logging and param loading
* Enable different interfaces between local planner and controller
* Use JointGroupPositionController as demo hardware controller
henningkayser pushed a commit to henningkayser/moveit2 that referenced this pull request Jul 6, 2021
* Add forward_trajectory local solver plugin (moveit#359)
* Use ros2_control based joint simulation and remove unnecessary comment
* Update copyrights
* Restructure hybrid planning package
* Fix formatting and add missing time stamp in local solver plugin
* Remove unnecessary logging and param loading
* Enable different interfaces between local planner and controller
* Use JointGroupPositionController as demo hardware controller
sjahr added a commit to sjahr/moveit2 that referenced this pull request Aug 21, 2021
* Add forward_trajectory local solver plugin (moveit#359)
* Use ros2_control based joint simulation and remove unnecessary comment
* Update copyrights
* Restructure hybrid planning package
* Fix formatting and add missing time stamp in local solver plugin
* Remove unnecessary logging and param loading
* Enable different interfaces between local planner and controller
* Use JointGroupPositionController as demo hardware controller
sjahr added a commit to sjahr/moveit2 that referenced this pull request Sep 28, 2021
* Add forward_trajectory local solver plugin (moveit#359)
* Use ros2_control based joint simulation and remove unnecessary comment
* Update copyrights
* Restructure hybrid planning package
* Fix formatting and add missing time stamp in local solver plugin
* Remove unnecessary logging and param loading
* Enable different interfaces between local planner and controller
* Use JointGroupPositionController as demo hardware controller
sjahr added a commit to sjahr/moveit2 that referenced this pull request Oct 19, 2021
* Add forward_trajectory local solver plugin (moveit#359)
* Use ros2_control based joint simulation and remove unnecessary comment
* Update copyrights
* Restructure hybrid planning package
* Fix formatting and add missing time stamp in local solver plugin
* Remove unnecessary logging and param loading
* Enable different interfaces between local planner and controller
* Use JointGroupPositionController as demo hardware controller
sjahr added a commit to sjahr/moveit2 that referenced this pull request Oct 28, 2021
* Add forward_trajectory local solver plugin (moveit#359)
* Use ros2_control based joint simulation and remove unnecessary comment
* Update copyrights
* Restructure hybrid planning package
* Fix formatting and add missing time stamp in local solver plugin
* Remove unnecessary logging and param loading
* Enable different interfaces between local planner and controller
* Use JointGroupPositionController as demo hardware controller
sjahr added a commit to sjahr/moveit2 that referenced this pull request Nov 18, 2021
* Add forward_trajectory local solver plugin (moveit#359)
* Use ros2_control based joint simulation and remove unnecessary comment
* Update copyrights
* Restructure hybrid planning package
* Fix formatting and add missing time stamp in local solver plugin
* Remove unnecessary logging and param loading
* Enable different interfaces between local planner and controller
* Use JointGroupPositionController as demo hardware controller
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Nov 24, 2021
* Add forward_trajectory local solver plugin (moveit#359)
* Use ros2_control based joint simulation and remove unnecessary comment
* Update copyrights
* Restructure hybrid planning package
* Fix formatting and add missing time stamp in local solver plugin
* Remove unnecessary logging and param loading
* Enable different interfaces between local planner and controller
* Use JointGroupPositionController as demo hardware controller
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Nov 29, 2021
* Add forward_trajectory local solver plugin (moveit#359)
* Use ros2_control based joint simulation and remove unnecessary comment
* Update copyrights
* Restructure hybrid planning package
* Fix formatting and add missing time stamp in local solver plugin
* Remove unnecessary logging and param loading
* Enable different interfaces between local planner and controller
* Use JointGroupPositionController as demo hardware controller
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Nov 30, 2021
* Add forward_trajectory local solver plugin (moveit#359)
* Use ros2_control based joint simulation and remove unnecessary comment
* Update copyrights
* Restructure hybrid planning package
* Fix formatting and add missing time stamp in local solver plugin
* Remove unnecessary logging and param loading
* Enable different interfaces between local planner and controller
* Use JointGroupPositionController as demo hardware controller
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Dec 3, 2021
* Add forward_trajectory local solver plugin (moveit#359)
* Use ros2_control based joint simulation and remove unnecessary comment
* Update copyrights
* Restructure hybrid planning package
* Fix formatting and add missing time stamp in local solver plugin
* Remove unnecessary logging and param loading
* Enable different interfaces between local planner and controller
* Use JointGroupPositionController as demo hardware controller
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Dec 7, 2021
* Add forward_trajectory local solver plugin (moveit#359)
* Use ros2_control based joint simulation and remove unnecessary comment
* Update copyrights
* Restructure hybrid planning package
* Fix formatting and add missing time stamp in local solver plugin
* Remove unnecessary logging and param loading
* Enable different interfaces between local planner and controller
* Use JointGroupPositionController as demo hardware controller
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Dec 7, 2021
* Add forward_trajectory local solver plugin (moveit#359)
* Use ros2_control based joint simulation and remove unnecessary comment
* Update copyrights
* Restructure hybrid planning package
* Fix formatting and add missing time stamp in local solver plugin
* Remove unnecessary logging and param loading
* Enable different interfaces between local planner and controller
* Use JointGroupPositionController as demo hardware controller
MikeWrock pushed a commit to MikeWrock/moveit2 that referenced this pull request Aug 15, 2022
Signed-off-by: Tyler Weaver <tylerjw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants