Example reference logger approach#33
Closed
davetcoleman wants to merge 2 commits intomoveit:masterfrom
davetcoleman:robot_state_logger
Closed
Example reference logger approach#33davetcoleman wants to merge 2 commits intomoveit:masterfrom davetcoleman:robot_state_logger
davetcoleman wants to merge 2 commits intomoveit:masterfrom
davetcoleman:robot_state_logger
Conversation
Closed
rhaschke
approved these changes
Mar 6, 2019
Contributor
rhaschke
left a comment
There was a problem hiding this comment.
Looks reasonable to me.
mlautman
reviewed
Mar 7, 2019
This was referenced Mar 11, 2019
Closed
vmayoral
reviewed
Mar 16, 2019
Member
Author
|
I think logging has been figured out adequately at this point, closing this PR. |
MikeWrock
pushed a commit
to MikeWrock/moveit2
that referenced
this pull request
Aug 15, 2022
moveit#33) * renaming prerequisites to getting started, removing 'tutorial' from tutorial names, improving index page, and small changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference implementation for converting moveit1's standard of LOGNAME as documented in the Style Guidelines to moveit2.
I'm not a ROS2 expert and I can't test if this compiles, so use this PR as a discussion point. Its based on @vmayoral's original implementation but is adapted for the discussions ongoing in #21
The key thing to recognize is that the moveit maintainers have been making a concerted effort use namespace everything in the moveit codebase, and more recently we've been trying to do this with the LOGNAME approach as recommended by @rhaschke. Sticking to this standard will improve compatibility between moveit1/2 and also just make for cleaner, more concise code.
I believe, according to @wjwwood's detailed explanation here this will result in the following output:
If we like this approach, and it is verified to build in a module of moveit_core, I think we can then quickly propagate it through all of the moveit code base using find-replace at the command line.