⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 91.83673% with 4 lines in your changes missing coverage. Please review.

Project coverage is 45.62%. Comparing base (870b23d) to head (22887a5).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #3280      +/-   ##
==========================================
- Coverage   45.94%   45.62%   -0.31%     
==========================================
  Files         716      716              
  Lines       62393    62410      +17     
  Branches     7543     7550       +7     
==========================================
- Hits        28659    28471     -188     
- Misses      33568    33772     +204     
- Partials      166      167       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The changes look good. Could we cherry-pick these changes without committing, then adapt them for ROS 2? This would help preserve the original authorship. Thanks!

I tried to patch the changes across, but I'm not very familiar with git patches, and there were enough changes on the ROS2 side (primarily removing moveit::core:: namespaces and similar) that the patches wouldn't apply.

If you could talk me though how to port these properly I will happily do that instead.

I think the test failure is unrelated to this PR. Could someone with the relevant permissions re-run the failed test, to see if it's sporadic?

I think the test failure is unrelated to this PR. Could someone with the relevant permissions re-run the failed test, to see if it's sporadic?

Test flakiness has been quite bad lately...

The changes look good. Could we cherry-pick these changes without committing, then adapt them for ROS 2? This would help preserve the original authorship. Thanks!

I tried to patch the changes across, but I'm not very familiar with git patches, and there were enough changes on the ROS2 side (primarily removing moveit::core:: namespaces and similar) that the patches wouldn't apply.

If you could talk me though how to port these properly I will happily do that instead.

@rr-mark MoveIt2 was forked from MoveIt1 so you should be able to add moveit1 as a remote repository in your local copy and then just cherry-pick the commits to MoveIt2.

@rr-mark MoveIt2 was forked from MoveIt1 so you should be able to add moveit1 as a remote repository in your local copy and then just cherry-pick the commits to MoveIt2.

Ah, thanks, I'll try that later (on this and #3247)

Closed in favour of #3284