Ports #3676 and #3682 from ros1 moveit#3247
Closed
riv-mjohnson wants to merge 11 commits intomoveit:mainfrom
Closed
Ports #3676 and #3682 from ros1 moveit#3247riv-mjohnson wants to merge 11 commits intomoveit:mainfrom
riv-mjohnson wants to merge 11 commits intomoveit:mainfrom
Conversation
…h previous ports in this file)
rhaschke
reviewed
Jan 16, 2025
Contributor
rhaschke
left a comment
There was a problem hiding this comment.
At first sight this looks reasonable.
moveit_ros/move_group/src/default_capabilities/execute_trajectory_action_capability.cpp
Outdated
Show resolved
Hide resolved
…er to callback group.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3247 +/- ##
==========================================
+ Coverage 45.65% 45.66% +0.01%
==========================================
Files 714 714
Lines 62298 62287 -11
Branches 7532 7531 -1
==========================================
- Hits 28437 28436 -1
+ Misses 33695 33684 -11
- Partials 166 167 +1 ☔ View full report in Codecov by Sentry. |
Contributor
Author
This was referenced Jan 30, 2025
Contributor
Author
|
Closed in favour of #3283 |
This was referenced Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ports moveit/moveit#3676 and moveit/moveit#3682
Could this be back-ported to humble when merged
Checklist