Enhancement/ports moveit 3522 (backport #3070)#3074
Merged
Conversation
* Makes PTP changes * Makes LIN changes * Makes CIRC changes * Makes CIRC changes * Makes CIRC changes * Makes CIRC changes * Makes LIN changes * Makes LIN changes * Fixes formatting * Replace ROS_WARN with RCLCPP_WARN * Fixes formatting * Fixes RCLCPP_WARN calls * Fixes compiler errors * Fixes if statement * Fixes formatting * Fixes msg type (cherry picked from commit 4c28a74)
sea-bass
approved these changes
Nov 11, 2024
Contributor
|
@sjahr Would you mind taking a look at this when you get a chance? Thanks! |
Contributor
|
@sjahr I think this test failure is unrelated as the PlanningSceneMonitor has not been touched. Would it be possible to rerun the workflows? |
Contributor
This has happened on the first CI job for every new PR that's come into humble. I suspect it's because the Humble cache source is out of date until #3082 lands and finally fixes/is able to push the Humble Docker image. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ports moveit/moveit#3522 to moveit2. Should fix #2857
Checklist
This is an automatic backport of pull request #3070 done by [Mergify](https://mergify.com).