Skip to content

Cleanup #3056#3058

Merged
sea-bass merged 4 commits intomoveit:mainfrom
rhaschke:cleanup-3056
Nov 5, 2024
Merged

Cleanup #3056#3058
sea-bass merged 4 commits intomoveit:mainfrom
rhaschke:cleanup-3056

Conversation

@rhaschke
Copy link
Contributor

@rhaschke rhaschke commented Nov 4, 2024

Addresses #3056 (review).

sea-bass
sea-bass previously approved these changes Nov 4, 2024
Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sea-bass sea-bass dismissed their stale review November 4, 2024 13:25

Failed test

Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Thank you!

@sea-bass sea-bass enabled auto-merge November 5, 2024 18:19
@sea-bass sea-bass added this pull request to the merge queue Nov 5, 2024
Merged via the queue into moveit:main with commit 36487d1 Nov 5, 2024
@rhaschke rhaschke deleted the cleanup-3056 branch November 5, 2024 20:22
Markus-Simonsen pushed a commit to Markus-Simonsen/moveit2 that referenced this pull request Aug 12, 2025
* Cleanup moveit#3056

* Switch to PSM's waitForCurrentRobotState()

* Back to StateMonitor usage

and explicitly propagate state update to PlanningScene
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants