Reverts default launch argument "capabilities" to not cause an error#2912
Closed
b-adkins wants to merge 2 commits intomoveit:humblefrom
Closed
Reverts default launch argument "capabilities" to not cause an error#2912b-adkins wants to merge 2 commits intomoveit:humblefrom
b-adkins wants to merge 2 commits intomoveit:humblefrom
Conversation
…96, which broke MoveIt launch files output by the setup assistant.
Closed
sea-bass
approved these changes
Aug 8, 2024
|
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
|
Please target the |
Contributor
|
I would suggest we take #3018 instead of this at it fixes the issue but also keeps the "new" feature that was intended (and then back port it to humble/iron as well) |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts capabilities default value to the empty string. Reverts #2696.
The issue is extensively documented:
Description
Reverted the backport to the empty string, which it was before the merge that apparently broke things. Alternatively,
was suggested in these discussions. Both worked on my system.