[Servo] Fix collision checking with attached objects (backport #2747)#2754
Merged
[Servo] Fix collision checking with attached objects (backport #2747)#2754
Conversation
(cherry picked from commit 68e8680)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## iron #2754 +/- ##
==========================================
+ Coverage 51.08% 51.08% +0.01%
==========================================
Files 385 385
Lines 31983 31984 +1
==========================================
+ Hits 16334 16335 +1
Misses 15649 15649 ☔ View full report in Codecov by Sentry. |
sjahr
approved these changes
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a slight fix to the MoveIt Servo collision checker to make it work with attached objects.
Turns out Current State Monitor has some issues, but Planning Scene Monitor works fine: #2748
Checklist
This is an automatic backport of pull request #2747 done by [Mergify](https://mergify.com).