Skip to content

[Servo] Fix collision checking with attached objects (backport #2747)#2754

Merged
sjahr merged 3 commits intoironfrom
mergify/bp/iron/pr-2747
Mar 22, 2024
Merged

[Servo] Fix collision checking with attached objects (backport #2747)#2754
sjahr merged 3 commits intoironfrom
mergify/bp/iron/pr-2747

Conversation

@mergify
Copy link

@mergify mergify bot commented Mar 19, 2024

Description

This PR introduces a slight fix to the MoveIt Servo collision checker to make it work with attached objects.

Turns out Current State Monitor has some issues, but Planning Scene Monitor works fine: #2748

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #2747 done by [Mergify](https://mergify.com).

@codecov
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.08%. Comparing base (0a27609) to head (80e173a).
Report is 2 commits behind head on iron.

❗ Current head 80e173a differs from pull request most recent head 1b38efc. Consider uploading reports for the commit 1b38efc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             iron    #2754      +/-   ##
==========================================
+ Coverage   51.08%   51.08%   +0.01%     
==========================================
  Files         385      385              
  Lines       31983    31984       +1     
==========================================
+ Hits        16334    16335       +1     
  Misses      15649    15649              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjahr sjahr self-requested a review March 22, 2024 09:18
@sjahr sjahr merged commit 5108826 into iron Mar 22, 2024
@sjahr sjahr deleted the mergify/bp/iron/pr-2747 branch March 22, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants