Skip to content

Fix launch parameters in Servo demos#2735

Merged
henningkayser merged 3 commits intomainfrom
fix-servo-demos
Mar 19, 2024
Merged

Fix launch parameters in Servo demos#2735
henningkayser merged 3 commits intomainfrom
fix-servo-demos

Conversation

@sea-bass
Copy link
Copy Markdown
Contributor

@sea-bass sea-bass commented Mar 10, 2024

Description

This PR fixes the launch parameters of all the MoveIt Servo demos to be consistent with the new acceleration limited smoothing plugin.

Note this also requires moveit/moveit_resources#198 (on rolling)

Closes #2733.

cc @ibrahiminfinite

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@sea-bass sea-bass requested review from AndyZe, pac48 and sjahr March 10, 2024 14:21
@sea-bass sea-bass self-assigned this Mar 10, 2024
@sea-bass
Copy link
Copy Markdown
Contributor Author

rolling is broken now likely because of the upcoming 24.04 sync, but I think we can go ahead here

@henningkayser henningkayser merged commit 4f09308 into main Mar 19, 2024
@henningkayser henningkayser deleted the fix-servo-demos branch March 19, 2024 14:07
@747309172a-cpu
Copy link
Copy Markdown

Description

This PR fixes the launch parameters of all the MoveIt Servo demos to be consistent with the new acceleration limited smoothing plugin.

Note this also requires moveit/moveit_resources#198 (on rolling)

Closes #2733.

cc @ibrahiminfinite

Checklist

* [x]  **Required by CI**: Code is auto formatted using [clang-format](http://moveit.ros.org/documentation/contributing/code)

* [x]  Extend the tutorials / documentation [reference](http://moveit.ros.org/documentation/contributing/)

* [x]  Document API changes relevant to the user in the [MIGRATION.md](https://github.com/ros-planning/moveit2/blob/main/MIGRATION.md) notes

* [x]  Create tests, which fail without this PR [reference](https://moveit.picknik.ai/humble/doc/examples/tests/tests_tutorial.html)

* [x]  Include a screenshot if changing a GUI

* [x]  While waiting for someone to review your request, please help review [another open pull request](https://github.com/ros-planning/moveit2/pulls) to support the maintainers

I am using MoveIt Servo, and the computed results differ significantly from the actual measured end-effector velocity. When I change the publish_period parameter, the discrepancy improves. What could be the possible reason for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Servo] Demos failing

4 participants