Skip to content

Port moveit_ros_benchmarks#225

Merged
henningkayser merged 10 commits intomoveit:masterfrom
RoboticsYY:pr-moveit_ros_benchmarks
Jul 22, 2020
Merged

Port moveit_ros_benchmarks#225
henningkayser merged 10 commits intomoveit:masterfrom
RoboticsYY:pr-moveit_ros_benchmarks

Conversation

@RoboticsYY
Copy link
Copy Markdown
Contributor

@RoboticsYY RoboticsYY commented Jun 24, 2020 •
edited
Loading

Description

This PR intends to port the moveit_ros_benchmarks to ROS2.

Run benchmark demo:

  1. Update moveit_resources with this commit

  2. Run benchmark for ompl:

ros2 launch moveit_ros_benchmarks demo_panda_predefined_poses.launch.py
  1. View results:
ros2 run moveit_ros_benchmarks moveit_benchmark_statistics.py -p plot.pdf /tmp/moveit_benchmarks/KitchenPick1_ready_extended_yy-NUC7i7DNHE_2020-07-13T11\:33\:06.076907.log

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 24, 2020 •
edited
Loading

Codecov Report

Merging #225 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #225   +/-   ##
=======================================
  Coverage   47.35%   47.35%           
=======================================
  Files         143      143           
  Lines       13347    13347           
=======================================
  Hits         6321     6321           
  Misses       7026     7026

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6477cd5...cf48284. Read the comment docs.

@RoboticsYY RoboticsYY force-pushed the pr-moveit_ros_benchmarks branch 3 times, most recently from ef83902 to 235f058 Compare July 1, 2020 08:24
@RoboticsYY RoboticsYY force-pushed the pr-moveit_ros_benchmarks branch 2 times, most recently from 8f0c260 to 16fb672 Compare July 12, 2020 10:07
@RoboticsYY RoboticsYY changed the title [WIP] Port moveit_ros_benchmarks Port moveit_ros_benchmarks Jul 12, 2020
@RoboticsYY RoboticsYY force-pushed the pr-moveit_ros_benchmarks branch from 16fb672 to eeb062b Compare July 13, 2020 12:14
henningkayser
henningkayser approved these changes Jul 19, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RoboticsYY Very clean port, I didn't find anything to object 👍 . Please rebase and then lgtm.

@RoboticsYY RoboticsYY force-pushed the pr-moveit_ros_benchmarks branch from eeb062b to cf48284 Compare July 20, 2020 13:49
@RoboticsYY
Copy link
Copy Markdown
Contributor Author

RoboticsYY commented Jul 20, 2020

@henningkayser Thanks! I have rebased this PR against the master branch.

@henningkayser henningkayser merged commit 73ee4b8 into moveit:master Jul 22, 2020
MikeWrock pushed a commit to MikeWrock/moveit2 that referenced this pull request Aug 15, 2022
Disable 429 errors (moveit#225)
3215bec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henningkayser henningkayser henningkayser approved these changes

@JafarAbdi JafarAbdi Awaiting requested review from JafarAbdi

@tylerjw tylerjw Awaiting requested review from tylerjw

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RoboticsYY @henningkayser