[Servo] Restore namespace to parameters#2171
Merged
sjahr merged 2 commits intomoveit:mainfrom May 11, 2023
Merged
Conversation
695695e to
3dbe22f
Compare
Contributor
Author
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2171 +/- ##
==========================================
- Coverage 50.48% 50.47% -0.00%
==========================================
Files 387 387
Lines 31790 31790
==========================================
- Hits 16047 16044 -3
- Misses 15743 15746 +3
☔ View full report in Codecov by Sentry. |
sjahr
approved these changes
May 11, 2023
sea-bass
reviewed
May 11, 2023
sea-bass
approved these changes
May 11, 2023
Contributor
sea-bass
left a comment
There was a problem hiding this comment.
I did mean to approve the PR, since my comment is minor
217d25b to
72ae89e
Compare
sea-bass
approved these changes
May 11, 2023
sjahr
pushed a commit
to PickNikRobotics/moveit2
that referenced
this pull request
May 12, 2023
* Add namespace to parameters * Minor cleanups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2162
This PR adds the
moveit_servonamespace to MoveIt Servo parameters.Checklist