Skip to content

Add new sub-module to moveit_core, logging#2

Merged
mlautman merged 1 commit intomoveit:masterfrom
AcutronicRobotics:logging
Feb 19, 2019
Merged

Add new sub-module to moveit_core, logging#2
mlautman merged 1 commit intomoveit:masterfrom
AcutronicRobotics:logging

Conversation

@vmayoral
Copy link
Copy Markdown
Contributor

No description provided.

Consolidate logging within moveit_core by creating a dedicated
submodule that integrates prior ROS macros
/* Author: Víctor Mayoral Vilches */

#ifndef MOVEIT_LOGGING_
#define MOVEIT_LOGGING_
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#define MOVEIT_LOGGING_
#define MOVEIT_MACROS_LOGGING_


/* Author: Víctor Mayoral Vilches */

#ifndef MOVEIT_LOGGING_
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#ifndef MOVEIT_LOGGING_
#ifndef MOVEIT_MACROS_LOGGING_

@mlautman mlautman merged commit f4462fc into moveit:master Feb 19, 2019
@mlautman
Copy link
Copy Markdown
Contributor

@vmayoral I approved and merged before I saw @davetcoleman's feedback. Please apply those changes in a new PR

mlautman pushed a commit that referenced this pull request Mar 8, 2019
seanyen referenced this pull request in seanyen/moveit2 Jul 21, 2020
henningkayser pushed a commit that referenced this pull request Aug 28, 2020
backport fixes, some cleanup

clang format fixes

more cleanup + clang format #2
henningkayser pushed a commit that referenced this pull request Aug 28, 2020
clang format fixes #2

cmake style fixes, clang warning fixes

revert clang warning fixes

rebase fixes
henningkayser added a commit that referenced this pull request Aug 28, 2020
AndyZe referenced this pull request in AndyZe/moveit2 Sep 6, 2020
backport fixes, some cleanup

clang format fixes

more cleanup + clang format #2
AndyZe referenced this pull request in AndyZe/moveit2 Sep 6, 2020
clang format fixes #2

cmake style fixes, clang warning fixes

revert clang warning fixes

rebase fixes
AndyZe referenced this pull request in AndyZe/moveit2 Sep 6, 2020
galou pushed a commit to galou/moveit2 that referenced this pull request Mar 4, 2022
Km devel galactic changes, included:
added separate private node and it's SingleThreadedExecutor to perfor…  3910e52
Get parameter trajectory_execution.execution_duration_monitoring in…  b533006
Use emulated time in action-based controller [GE, JD] d1755a7
Use a steady clock for timeout for IK [GE] 7311f41
MikeWrock referenced this pull request in MikeWrock/moveit2 Aug 15, 2022
* updated images with Panda
* removing old PR2 images
* updating setup assistant tutorial
shashwat-aivot referenced this pull request in AivotRobotics/moveit2 Mar 19, 2023
sjahr added a commit that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants