Skip to content

Scale acceleration and velocity of cartesian interpolations in MoveGroupCartesianPathService#1968

Merged
henningkayser merged 6 commits intomoveit:mainfrom
Yadunund:yadu/scale_get_cartesian_path
May 8, 2023
Merged

Scale acceleration and velocity of cartesian interpolations in MoveGroupCartesianPathService#1968
henningkayser merged 6 commits intomoveit:mainfrom
Yadunund:yadu/scale_get_cartesian_path

Conversation

@Yadunund
Copy link
Copy Markdown
Contributor

@Yadunund Yadunund commented Feb 23, 2023

Description

Fixes #1967
Requires moveit/moveit_msgs#154

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d53f785) 50.87% compared to head (4352306) 50.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1968      +/-   ##
==========================================
- Coverage   50.87%   50.86%   -0.00%     
==========================================
  Files         391      391              
  Lines       32153    32153              
==========================================
- Hits        16356    16353       -3     
- Misses      15797    15800       +3     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sjahr sjahr self-assigned this Apr 13, 2023
@sjahr sjahr requested review from henningkayser and sjahr April 13, 2023 09:39
@henningkayser henningkayser merged commit 7356c53 into moveit:main May 8, 2023
sjahr added a commit to PickNikRobotics/moveit2 that referenced this pull request May 12, 2023
@Yadunund Yadunund deleted the yadu/scale_get_cartesian_path branch May 15, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GetCartesianPath service does not allow velocity and accelerations to be scaled.

3 participants