Skip to content

Update pre-commit run on Ubuntu 22.04#1339

Merged
henningkayser merged 1 commit intomoveit:mainfrom
vatanaksoytezer:vatan/update_clangf
Jun 13, 2022
Merged

Update pre-commit run on Ubuntu 22.04#1339
henningkayser merged 1 commit intomoveit:mainfrom
vatanaksoytezer:vatan/update_clangf

Conversation

@vatanaksoytezer
Copy link
Copy Markdown
Contributor

Although our main branch is meant to run on Ubuntu 22.04 our pre-commit was running on ubuntu-latest which still targets Ubuntu 20.04. This PR should fix this

@vatanaksoytezer vatanaksoytezer added the backport-humble Mergify label that triggers a PR backport to Humble label Jun 11, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 11, 2022

Codecov Report

Merging #1339 (44ea0a2) into main (c13a2fd) will decrease coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1339      +/-   ##
==========================================
- Coverage   61.58%   61.36%   -0.21%     
==========================================
  Files         274      274              
  Lines       24966    24966              
==========================================
- Hits        15372    15318      -54     
- Misses       9594     9648      +54     
Impacted Files Coverage Δ
...nning_scene_monitor/src/planning_scene_monitor.cpp 40.79% <0.00%> (-4.49%) ⬇️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 75.36% <0.00%> (-1.07%) ⬇️
...e/collision_detection_fcl/src/collision_common.cpp 73.08% <0.00%> (-0.67%) ⬇️
moveit_core/planning_scene/src/planning_scene.cpp 51.95% <0.00%> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c13a2fd...44ea0a2. Read the comment docs.

@tylerjw tylerjw force-pushed the vatan/update_clangf branch from 5b85d24 to 44ea0a2 Compare June 11, 2022 21:18
Copy link
Copy Markdown
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I was already wondering about these showing up, but didn't investigate it further. Thanks!

@henningkayser henningkayser merged commit 541baa8 into moveit:main Jun 13, 2022
mergify bot pushed a commit that referenced this pull request Jun 13, 2022
JafarAbdi pushed a commit that referenced this pull request Jun 13, 2022
(cherry picked from commit 541baa8)

Co-authored-by: Vatan Aksoy Tezer <vatan@picknik.ai>
peterdavidfagan pushed a commit to peterdavidfagan/moveit2 that referenced this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-humble Mergify label that triggers a PR backport to Humble

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants