moveit_core: Remove unnecessary rclcpp.hpp includes#1333
Merged
henningkayser merged 3 commits intomoveit:mainfrom Jun 14, 2022
Merged
moveit_core: Remove unnecessary rclcpp.hpp includes#1333henningkayser merged 3 commits intomoveit:mainfrom
henningkayser merged 3 commits intomoveit:mainfrom
Conversation
Member
Author
|
If anyone is interested in helping, please let me know, we have 37 packages and this PR only touch one :D |
856900f to
5014e24
Compare
Member
Author
|
Ok, I did the same for the whole codebase, I got ~286s reduction see https://gist.github.com/JafarAbdi/cd9735c2eb9cdf6e8906e057c9b18590 |
7d1d55d to
4ed6ecb
Compare
tylerjw
approved these changes
Jun 10, 2022
Member
tylerjw
left a comment
There was a problem hiding this comment.
This is a really nice change, thank you.
Contributor
|
I got ~286s reduction
Wow... Just wow.
|
6 tasks
henningkayser
approved these changes
Jun 13, 2022
42f9c7a to
4551c69
Compare
4551c69 to
3a5732a
Compare
peterdavidfagan
pushed a commit
to peterdavidfagan/moveit2
that referenced
this pull request
Jul 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Using https://github.com/aras-p/ClangBuildAnalyzer to profile the compile time for the whole codebase I found out rclcpp.hpp is one of the most expensive headers: https://gist.github.com/JafarAbdi/965b23666d4aeca92990554629b45644
So this PR removes unnecessary rclcpp.hpp includes from moveit_core which result in ~55s reduction in compile time (without parallel build)
Before:
After: