Decorate MoveItConfigs with dataclass#1308
Merged
henningkayser merged 1 commit intomoveit:mainfrom Jun 3, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1308 +/- ##
==========================================
- Coverage 61.48% 61.46% -0.01%
==========================================
Files 274 274
Lines 24940 24940
==========================================
- Hits 15332 15328 -4
- Misses 9608 9612 +4
Continue to review full report at Codecov.
|
vatanaksoytezer
approved these changes
Jun 2, 2022
Contributor
vatanaksoytezer
left a comment
There was a problem hiding this comment.
Looks much cleaner!
8c88efa to
28f67ec
Compare
henningkayser
approved these changes
Jun 2, 2022
Member
henningkayser
left a comment
There was a problem hiding this comment.
This looks very nice! I assume this is fully compatible with the old version?
Member
Author
This uses a feature from Python 3.10, so it only work with Jammy |
28f67ec to
43a3c3f
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jun 3, 2022
(cherry picked from commit 4502659)
henningkayser
pushed a commit
that referenced
this pull request
Jun 6, 2022
peterdavidfagan
pushed a commit
to peterdavidfagan/moveit2
that referenced
this pull request
Jul 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix: #1292 (comment), this reduces the duplication and make the class easier to read
Checklist