Merged
Conversation
JafarAbdi
commented
Oct 21, 2019
This was referenced Oct 21, 2019
moveit_ros/planning/rdf_loader/include/moveit/rdf_loader/rdf_loader.h
Outdated
Show resolved
Hide resolved
Closed
Member
henningkayser
left a comment
There was a problem hiding this comment.
This looks pretty good so far. +1 from me after you fixed up the remaining changes
henningkayser
approved these changes
Oct 31, 2019
This was referenced Nov 21, 2019
Closed
0739631 to
83c9ba4
Compare
| std::string content; | ||
| auto start = std::chrono::system_clock::now(); | ||
|
|
||
| if (!nh.searchParam(robot_description, robot_description_) || !nh.getParam(robot_description_, content)) |
Member
There was a problem hiding this comment.
I'm not sure I'm happy with the new implementation, has_parameter() + get_parameter seems like an overhead to me. Also, we need to discuss how searchParam() should be implemented. @mkhansen-intel do you have any suggestions for this part?
83c9ba4 to
478ac98
Compare
180c194 to
2073c64
Compare
MikeWrock
pushed a commit
to MikeWrock/moveit2
that referenced
this pull request
Aug 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a continuation of PR#76
The addressed review was added to the master branch see but because I'm not able to cherry-pick the changes for the specific files of rdf_loader, I just applied the changes to the rdf_loader and committed them