Skip to content

Fix octomap display#3385

Merged
rhaschke merged 3 commits intomoveit:masterfrom
ubi-agni:fix-octomap-display
Mar 24, 2023
Merged

Fix octomap display#3385
rhaschke merged 3 commits intomoveit:masterfrom
ubi-agni:fix-octomap-display

Conversation

@rhaschke
Copy link
Copy Markdown
Contributor

Debugging #3380, I noticed several other issues than the main culprit which was already handled in #3134 (but not yet merged 😞):

  • fix a memory leak, not deleting octomap's scene nodes until the main PSD's node is destroyed
  • react to changes of octomap rendering

Changes to "Voxel Rendering" mode and "Voxel Coloring" were only
considered on the next planning scene update.
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03 🎉

Comparison is base (0819713) 61.70% compared to head (c3ee9d9) 61.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3385      +/-   ##
==========================================
+ Coverage   61.70%   61.72%   +0.03%     
==========================================
  Files         380      380              
  Lines       33587    33587              
==========================================
+ Hits        20720    20727       +7     
+ Misses      12867    12860       -7     

see 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant