renamed CSM::waitForCurrentState() to CSM::waitForCompleteState()#298
Merged
davetcoleman merged 1 commit intomoveit:kinetic-develfrom Oct 19, 2016
rhaschke:rename-waitForCurrentRobotState
Merged
renamed CSM::waitForCurrentState() to CSM::waitForCompleteState()#298davetcoleman merged 1 commit intomoveit:kinetic-develfrom rhaschke:rename-waitForCurrentRobotState
davetcoleman merged 1 commit intomoveit:kinetic-develfrom
rhaschke:rename-waitForCurrentRobotState
Conversation
v4hn
approved these changes
Oct 19, 2016
Contributor
v4hn
left a comment
There was a problem hiding this comment.
This change definitely makes sense and should be merged.
| } | ||
| return ok; | ||
| } | ||
| bool planning_scene_monitor::CurrentStateMonitor::waitForCurrentState(const std::string &group, double wait_time) const |
Contributor
There was a problem hiding this comment.
Please add an empty line between this function and the one above.
…State() .. to better reflect the actual semantics of the method to maintain API compatibility, the old function still exists, but is deprecated
davetcoleman
approved these changes
Oct 19, 2016
Member
|
Thanks! I am assuming a function change this invasive we do not want backported |
Contributor
+1 |
130s
pushed a commit
to 130s/moveit-2
that referenced
this pull request
Oct 21, 2016
…State() (moveit#298) .. to better reflect the actual semantics of the method to maintain API compatibility, the old function still exists, but is deprecated
130s
pushed a commit
to 130s/moveit-2
that referenced
this pull request
Oct 21, 2016
…State() (moveit#298) .. to better reflect the actual semantics of the method to maintain API compatibility, the old function still exists, but is deprecated
k-okada
pushed a commit
to k-okada/moveit
that referenced
this pull request
Dec 12, 2017
…State() (moveit#298) .. to better reflect the actual semantics of the method to maintain API compatibility, the old function still exists, but is deprecated Conflicts: moveit_ros/planning/planning_scene_monitor/include/moveit/planning_scene_monitor/current_state_monitor.h moveit_ros/planning/planning_scene_monitor/src/current_state_monitor.cpp moveit_ros/planning_interface/move_group_interface/src/move_group.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.. to better reflect the actual semantics of the method.
To maintain API compatibility, the old function still exists, but is deprecated.
Again, this is extracted from #232.