Codecov Report

Merging #2793 (1991b6c) into master (0a0fc56) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2793      +/-   ##
==========================================
- Coverage   62.12%   62.09%   -0.02%     
==========================================
  Files         375      375              
  Lines       33144    33144              
==========================================
- Hits        20586    20577       -9     
- Misses      12558    12567       +9     

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

With our internal jenkins CI we need to use the following as it otherwise shows the branch as "head"

if (DEFINED ENV{BRANCH_NAME})
    set(GIT_BRANCH $ENV{BRANCH_NAME})
else ()
    execute_process(
        COMMAND
            git rev-parse --abbrev-ref HEAD
        WORKING_DIRECTORY
            ${CMAKE_CURRENT_SOURCE_DIR}
        RESULT_VARIABLE
            GIT_BRANCH_RESULT
        OUTPUT_VARIABLE
            GIT_BRANCH
        OUTPUT_STRIP_TRAILING_WHITESPACE
    )
endif ()

don't know if that's need/works with github ci

You have to re-cmake to update the hash definition

That's a pretty harsh requirement and would lead to incorrect results for user workspaces (including mine) the whole time!
If somehow possible I would like to avoid that pitfall.

There is another solution that will force a re-configure of cmake before a build every time the HEAD commit changes

What does that mean for catkin workspaces? it's also a hassle if catkin_make/catkin build has to configure the whole workspace each time. If that should be the case (I would expect that), maybe there's a way to generate the hash entry at build-time instead of using configure_file?
EDIT: @jspricke just pointed out add_custom_command which is pretty much what I had in mind. It would still requires some scripting to get this to only touch the header if the version/commit changed.

Also, we probably want to add the hash as output to moveit_version

I fixed the open issues:

• using a custom command (and target) to regenerate version.h on every build
• fetching any branch or tag name to fix Generate version.h with git branch and commit hash #2793 (comment)