Skip to content

Readd missing TrajectoryConstraints functions for MoveitCommander#2429

Merged
v4hn merged 1 commit intomoveit:masterfrom
kevinshchang:add_missing_functions
Jul 20, 2021
Merged

Readd missing TrajectoryConstraints functions for MoveitCommander#2429
v4hn merged 1 commit intomoveit:masterfrom
kevinshchang:add_missing_functions

Conversation

@kevinshchang
Copy link
Copy Markdown
Contributor

@kevinshchang kevinshchang commented Nov 23, 2020 •
edited
Loading

Description

fix #2373

Does not look like this message is used other than in very specific applications, but currently the python wrapper uses functions that do not exist, which seems like it is still worth fixing.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@welcome
Copy link
Copy Markdown

welcome bot commented Nov 23, 2020

Thanks for helping in improving MoveIt and open source robotics!

felixvd
felixvd reviewed Nov 25, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@felixvd felixvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Are you using the constraint database yourself?

@kevinshchang
Copy link
Copy Markdown
Contributor Author

kevinshchang commented Nov 25, 2020

Thanks for fixing this! Are you using the constraint database yourself?

I am not using the database myself. I actually don't use this message either, but it was just something I noticed when playing with the python interface lol.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 26, 2020 •
edited
Loading

Codecov Report

Merging #2429 (4acbd7f) into master (95ab9ee) will increase coverage by 0.01%.
The diff coverage is 37.50%.

❗ Current head 4acbd7f differs from pull request most recent head 5de84ac. Consider uploading reports for the commit 5de84ac to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2429      +/-   ##
==========================================
+ Coverage   60.46%   60.47%   +0.01%     
==========================================
  Files         402      351      -51     
  Lines       29659    26460    -3199     
==========================================
- Hits        17931    15999    -1932     
+ Misses      11728    10461    -1267
Impacted Files Coverage Δ
...ove_group_interface/src/wrap_python_move_group.cpp 40.12% <37.50%> (+2.31%) ⬆️
...include/moveit/robot_model/prismatic_joint_model.h 0.00% <0.00%> (-75.00%) ⬇️
moveit_core/exceptions/src/exceptions.cpp 0.00% <0.00%> (-50.00%) ⬇️
...ilz_industrial_motion_planner_testutils/sequence.h 66.67% <0.00%> (-33.33%) ⬇️
...on/include/moveit/collision_detection/world_diff.h 0.00% <0.00%> (-33.33%) ⬇️
...tection/include/moveit/collision_detection/world.h 75.00% <0.00%> (-17.85%) ⬇️
...tup_assistant/src/tools/collision_matrix_model.cpp 0.00% <0.00%> (-14.73%) ⬇️
...ing/planning_request_adapter_plugins/src/empty.cpp 0.00% <0.00%> (-14.28%) ⬇️
...ion/include/moveit/plan_execution/plan_execution.h 66.67% <0.00%> (-13.33%) ⬇️
...gins/src/add_iterative_spline_parameterization.cpp 0.00% <0.00%> (-13.33%) ⬇️
... and 351 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95ab9ee...5de84ac. Read the comment docs.

davetcoleman
davetcoleman approved these changes May 3, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@davetcoleman davetcoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would appreciate another +1 from someone else as I'm not super at Python @felixvd

@davetcoleman
Copy link
Copy Markdown
Member

davetcoleman commented May 3, 2021

@kevinshchang could you resolve the conflicting file? sorry for the delay!

@kevinshchang @v4hn
fix trajectory constraints for moveit commander
5de84ac 
remove unimplemented ability to load trajectory constraints from str

Fixup by v4hn <me@v4hn.de>
@v4hn v4hn force-pushed the add_missing_functions branch from 3fd4044 to 5de84ac Compare June 26, 2021 23:25
@v4hn
Copy link
Copy Markdown
Contributor

v4hn commented Jun 26, 2021

I rebased and cleaned up the conflicts. Looks good (though not very useful) to me...

@v4hn v4hn merged commit 6fb94e5 into moveit:master Jul 20, 2021
@welcome
Copy link
Copy Markdown

welcome bot commented Jul 20, 2021

Congrats on getting your first MoveIt pull request merged and improving open source robotics!

sjahr added a commit to sjahr/moveit that referenced this pull request Jun 21, 2024
@sjahr
[Planning Pipeline Refactoring] #1 Simplify Adapter - Planner chain (m…
beec33d 
…oveit#2429)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davetcoleman davetcoleman davetcoleman approved these changes

@rhaschke rhaschke Awaiting requested review from rhaschke rhaschke is a code owner

+1 more reviewer

@felixvd felixvd felixvd left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MoveGroupCommander TrajectoryConstraints uses undeclared functions from C++ wrapper

4 participants

@kevinshchang @davetcoleman @v4hn @felixvd