python move_group interface: allow setting of targets from any iterable#184
Merged
v4hn merged 2 commits intomoveit:kinetic-develfrom Sep 2, 2016
rhaschke:python-iterable-as-target
Merged
python move_group interface: allow setting of targets from any iterable#184v4hn merged 2 commits intomoveit:kinetic-develfrom rhaschke:python-iterable-as-target
v4hn merged 2 commits intomoveit:kinetic-develfrom
rhaschke:python-iterable-as-target
Conversation
Member
|
Travis says the branch is missing? I skimmed the changes and it looks alright, but I'm not a python person |
Contributor
Author
I accidentally pushed my branch to ros-planning first instead of by own fork, which caused Travis to start building. The PR build succeeded. |
Contributor
|
The changes look nice and good to me, but I can't run the test cases over here. |
Contributor
Author
v4hn
pushed a commit
that referenced
this pull request
Sep 2, 2016
* moveit_commander: allow setting of targets from any iterable * disable cleanup test fails due to ros/ros_comm#871
v4hn
pushed a commit
that referenced
this pull request
Sep 2, 2016
* moveit_commander: allow setting of targets from any iterable * disable cleanup test fails due to ros/ros_comm#871
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The python MoveGroup interface only allowed to set joint targets from lists, dicts, and some special data structures. This PR
move_group.set_joint_value_target(), particularlynumpyarrays.This fails due to an upstream bug: fix static destruction order ros/ros_comm#871