fix remaining issues in #94#151
Merged
rhaschke merged 2 commits intomoveit:kinetic-develfrom Aug 26, 2016
rhaschke:fix#94
Merged
fix remaining issues in #94#151rhaschke merged 2 commits intomoveit:kinetic-develfrom rhaschke:fix#94
rhaschke merged 2 commits intomoveit:kinetic-develfrom
rhaschke:fix#94
Conversation
.. to allow correctly waiting infinite time for move_group's capabilities to come up
Switching to the correct WallDuration interface for MoveGroup, make the constructor ambigue if not the full signature is used. Removing the default values for the old constructor solves this issue. This will automatically choose the new version in this case.
| MOVEIT_DEPRECATED MoveGroup(const Options &opt, const boost::shared_ptr<tf::Transformer> &tf = boost::shared_ptr<tf::Transformer>(), | ||
| const ros::Duration &wait_for_servers = ros::Duration()); | ||
| MOVEIT_DEPRECATED MoveGroup(const Options &opt, const boost::shared_ptr<tf::Transformer> &tf, | ||
| const ros::Duration &wait_for_servers); |
Contributor
Author
There was a problem hiding this comment.
According to abi compliance checker this is fine: REPORT
Contributor
|
This is neither an API nor an ABI problem, nifty. LGTM +1 |
Contributor
Author
|
Cherry-picked into Jade. |
JafarAbdi
pushed a commit
to JafarAbdi/moveit
that referenced
this pull request
Mar 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We missed two issues before merging #94:
==WallDurationinterface forMoveGroupInterface, made the constructors ambigue if not the full signature is specified. Hence, I propose to remove the default values for the old constructor. This will automatically choose the new version, which is preferred anyway.Please also cherry-pick into Jade. #94 was not yet merged into Indigo. I will integrate this patch into #144 as well, which is the corresponding PR for Indigo.