Reduce spurious unittest failures due to randomness#1381
Merged
rhaschke merged 1 commit intomoveit:masterfrom Mar 7, 2019
Merged
Reduce spurious unittest failures due to randomness#1381rhaschke merged 1 commit intomoveit:masterfrom
rhaschke merged 1 commit intomoveit:masterfrom
Conversation
Kinematics unittests use random sampling, which might (randomly) cause the tests to fail. This fix reduces randomness by using a fixed seed to sample robot states. Additionally, the "searchIKWithCallback" test should resample dismissed samples as pointed out in moveit/moveit_kinematics_tests#16.
9 tasks
henningkayser
approved these changes
Mar 7, 2019
Member
henningkayser
left a comment
There was a problem hiding this comment.
I thought finding rare failures is the point of testing with randomness.
I agree, the sample size is more than high enough here to use deterministic numbers.
Just curious, why are some of the tests disabled?
Contributor
Author
No. We are just lazy and don't want to provide numerous samples manually. |
mayman99
pushed a commit
to mayman99/moveit
that referenced
this pull request
Mar 9, 2019
Kinematics unit tests use random sampling, which might (randomly) cause the tests to fail (unfortunately sampling many failing samples). This fix reduces randomness by using a fixed seed to sample robot states. Additionally, the "searchIKWithCallback" test should resample dismissed samples as pointed out in moveit/moveit_kinematics_tests#16.
sjahr
pushed a commit
to sjahr/moveit
that referenced
this pull request
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kinematics unittests use random sampling, which might (randomly) cause the tests to fail.
This fix reduces randomness by using a fixed seed to sample robot states.
Additionally, the "searchIKWithCallback" test should resample dismissed samples as pointed out
in moveit/moveit_kinematics_tests#16.