fix compatibility with KDL 1.3#1228
Merged
rhaschke merged 1 commit intomelodic-develfrom Nov 27, 2018
Merged
Conversation
- The previous VERSION_LESS check is broken, the orocos_kdl_VERSION is not evaluated in this context - The definition is not exported to third-party projects that might include the header. After all these headers are public API.
rhaschke
approved these changes
Nov 27, 2018
Contributor
rhaschke
left a comment
There was a problem hiding this comment.
The previous VERSION_LESS check is broken, the orocos_kdl_VERSION is not evaluated in this context.
I think it is. At least in my checks it was.
The definition is not exported to third-party projects.
That's true. So, your solution is better.
Contributor
Author
In this case that might again be a difference between kinetic & melodic. |
sjahr
pushed a commit
to sjahr/moveit
that referenced
this pull request
Jun 21, 2024
Signed-off-by: Tyler Weaver <tylerjw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous VERSION_LESS check is broken,
the orocos_kdl_VERSION is not evaluated in this context
The definition is not exported to third-party projects
that might include the header. After all these headers are public API.
Verified to compile with ROS kinetic + external kinematics plugin that include the headers (ur_kinematics).