Skip to content

Cleanup Variable Names and Logging#1179

Merged
davetcoleman merged 3 commits intomoveit:melodic-develfrom
davetcoleman:melodic-no-k-names
Nov 1, 2018
Merged

Cleanup Variable Names and Logging#1179
davetcoleman merged 3 commits intomoveit:melodic-develfrom
davetcoleman:melodic-no-k-names

Conversation

@davetcoleman
Copy link
Copy Markdown
Member

@davetcoleman davetcoleman commented Nov 1, 2018

  • Cleanup old kinematic_model and kinematic_state names
  • Replace kstate and kmodel with longer names
  • Add LOGNAME to planning_scene

In the early days of moveit RobotModel was KinematicModel and RobotState was KinematicState

This finishes the cleanup of that transition.

Do not cherry-pick backwards

@davetcoleman davetcoleman changed the title Melodic no k names Cleanup Variable Names and Logging Nov 1, 2018
rhaschke
rhaschke approved these changes Nov 1, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that you used automatic renaming of variables based on a C++ code model.
I didn't looked through all the changes. But I agree to those changes in general.

@felixvd
Copy link
Copy Markdown
Contributor

felixvd commented Nov 1, 2018

I like the change and can't see a problem.

@rhaschke rhaschke mentioned this pull request Nov 1, 2018
Merged
5 tasks
@davetcoleman davetcoleman merged commit a598f22 into moveit:melodic-devel Nov 1, 2018
@davetcoleman davetcoleman deleted the melodic-no-k-names branch November 1, 2018 16:59
@davetcoleman
Copy link
Copy Markdown
Member Author

davetcoleman commented Nov 1, 2018

automatic renaming of variables based on a C++ code model.

Not sure what you mean by that - I use emacs so don't have fancy tools, just command line grep + sed. What do you use for this kind of thing?

@rhaschke
Copy link
Copy Markdown
Contributor

rhaschke commented Nov 1, 2018

automatic renaming of variables based on a C++ code model.

I use emacs... What do you use for this kind of thing?

qtcreator provides a nice refactor function, based on clang's code model. So, you are sure to replace the correct things... You used to work with emacs for a long time, but fully switched to qtcreator for programming ;-)

@davetcoleman
Copy link
Copy Markdown
Member Author

davetcoleman commented Nov 3, 2018

I'm assuming you meant "I used to work with emacs..."

Yea, I've heard qtcreator is pretty good for ROS. Do you use the ROS industrial plugin? https://github.com/ros-industrial/ros_qtc_plugin

@rhaschke rhaschke mentioned this pull request Nov 11, 2018
Merged
10 tasks
@JeroenDM JeroenDM mentioned this pull request Jul 17, 2020
Merged
6 tasks
sjahr pushed a commit to sjahr/moveit that referenced this pull request Jun 21, 2024
Delete an unused variable and a redundant log message (moveit#1179)
d27518d 
Co-authored-by: Vatan Aksoy Tezer <vatan@picknik.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhaschke rhaschke rhaschke approved these changes

@jonbinney jonbinney Awaiting requested review from jonbinney

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davetcoleman @felixvd @rhaschke