tests/src/Validator/ValidatorRegistryTest.php (1)

22-22: Count update is correct, but consider adding explicit assertion.

The count correctly reflects the addition of DuplicateValuesValidator. However, consider adding an explicit assertion to verify its presence in the array for more comprehensive test coverage.

Add this assertion after line 21:

         $this->assertContains(SchemaValidator::class, $validators);
+        $this->assertContains(\MoveElevator\ComposerTranslationValidator\Validator\DuplicateValuesValidator::class, $validators);
         $this->assertCount(4, $validators);

src/Validator/DuplicateValuesValidator.php (2)

66-66: Remove unused parameter.

The $input parameter is not used in this method and should be removed to clean up the method signature.

-public function renderIssueSets(InputInterface $input, OutputInterface $output, array $issueSets): void
+public function renderIssueSets(InputInterface $input, OutputInterface $output, array $issueSets): void

Note: The parameter needs to remain for interface compliance with ValidatorInterface, but the static analysis tool is flagging it as unused.

---

46-49: Consider edge case for array_unique optimization.

The logic checks for count(array_unique($keys)) > 1 but this could be optimized. Since keys are added one by one, checking count($keys) > 1 after ensuring uniqueness would be more efficient.

-if (count(array_unique($keys)) > 1) {
-    $duplicates[$value] = array_unique($keys);
-}
+$uniqueKeys = array_unique($keys);
+if (count($uniqueKeys) > 1) {
+    $duplicates[$value] = $uniqueKeys;
+}

tests/src/Validator/DuplicateValuesValidatorTest.php (1)

208-213: Simplify string assertion.

The assertIsString check is redundant since the explain() method is guaranteed to return a string. Focus on testing the content instead.

 public function testExplain(): void
 {
     $validator = new DuplicateValuesValidator($this->loggerMock);
-    $this->assertIsString($validator->explain());
+    $explanation = $validator->explain();
+    $this->assertNotEmpty($explanation);
     $this->assertStringContainsString('duplicate values', $validator->explain());
 }

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

src/Validator/DuplicateValuesValidator.php (1)

64-66: $input is unused

renderIssueSets() receives InputInterface $input but never touches it; PHPMD flags this.
If the argument is truly unnecessary, drop it; otherwise use it (e.g. to honour verbosity options).

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

README.md (1)

49-55: Polish wording & capitalization in the “Supported Formats” table

Minor copy-editing will tighten the descriptions and avoid acronym tautology flagged by LanguageTool:

-| Format | Description                                                                                                  | Framework | Example files                          |
-|--------|--------------------------------------------------------------------------------------------------------------|-----------|----------------------------------------|
-| XLIFF  | Supports source/target translations in xliff language files. | [TYPO3 CMS](https://typo3.org/)          | `locallang.xlf`, `de.locallang.xlf`    |
-| Yaml   | Supports yaml language files.                     | [Symfony Framework](https://symfony.com/)          | `messages.en.yaml`, `messages.de.yaml` |
+| Format | Description                                                                      | Framework | Example files                          |
+|--------|----------------------------------------------------------------------------------|-----------|----------------------------------------|
+| XLIFF  | Supports source/target translations in XLIFF files. | [TYPO3 CMS](https://typo3.org/)          | `locallang.xlf`, `de.locallang.xlf`    |
+| YAML   | Supports YAML files.                                   | [Symfony Framework](https://symfony.com/)          | `messages.en.yaml`, `messages.de.yaml` |

– Replace “xliff/yaml language files” with concise “XLIFF/YAML files”.
– Capitalise “YAML” consistently, mirroring “XLIFF”.
No functional impact, just clearer docs.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro