feat: add Duplicates and Mismatch validators; enhance validation command options#3
Merged
konradmichalik merged 1 commit intomainfrom Jun 24, 2025
Merged
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe changes introduce a modular validation system for translation files, adding new validator classes for detecting key mismatches and duplicates. The command-line interface now supports specifying validators. Utility methods are added for resolving parsers and validators. Documentation is updated to reflect these enhancements, and tests are adjusted for duplicate detection. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Command as ValidateTranslationCommand
participant ParserUtil as ParserUtility
participant Validator as ValidatorInterface (e.g., MismatchValidator, DuplicatesValidator)
participant Output
User->>Command: Run validation command (optionally with --validator)
Command->>ParserUtil: resolveValidators() / resolveParserClasses()
ParserUtil-->>Command: List of validator class names
loop For each validator
Command->>Validator: validate(fileDetector, parserClass, allFiles)
Validator->>Output: Output validation results
end
Command->>User: Print summary and exit code
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (10)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This was referenced Jun 25, 2025
Merged
This was referenced Jul 2, 2025
Merged
This was referenced Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Documentation
Tests