Fix JsonView sorting and serializing#112
Merged
davidlatwe merged 2 commits intomottosso:masterfrom Oct 21, 2020
Merged
Conversation
This fixed the list element sorting.
Owner
Ah, and you also updated it upstream. You are amazing. :) I have nothing to add, this is great, welcome to merge. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix Bad ordering of PATH-like variables in Environment Tab #91, and update vendored
qjsonmodel.pyfrom the source project which can resolve the issue. Noted that I also move previous local changes out of vendored module.The full copy action in
JsonViewonly usestrconversion, so I change to usejson.dumpsto make it return valid json syntax string.