Skip to content

Fix JsonView sorting and serializing#112

Merged
davidlatwe merged 2 commits intomottosso:masterfrom
davidlatwe:fix-qjson-sorting
Oct 21, 2020
Merged

Fix JsonView sorting and serializing#112
davidlatwe merged 2 commits intomottosso:masterfrom
davidlatwe:fix-qjson-sorting

Conversation

@davidlatwe
Copy link
Collaborator

  • This PR fix Bad ordering of PATH-like variables in Environment Tab #91, and update vendored qjsonmodel.py from the source project which can resolve the issue. Noted that I also move previous local changes out of vendored module.

  • The full copy action in JsonView only use str conversion, so I change to use json.dumps to make it return valid json syntax string.

@mottosso
Copy link
Owner

This PR fix #91, and update vendored qjsonmodel.py from the source project which can resolve the issue. Noted that I also move previous local changes out of vendored module.

Ah, and you also updated it upstream. You are amazing. :)

I have nothing to add, this is great, welcome to merge. :)

@davidlatwe davidlatwe merged commit 2a7b10b into mottosso:master Oct 21, 2020
@davidlatwe davidlatwe deleted the fix-qjson-sorting branch October 21, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bad ordering of PATH-like variables in Environment Tab

2 participants