[Python] Fix list element sorting in view, add QJsonModel.clear#17
Merged
dridk merged 2 commits intodridk:masterfrom Oct 20, 2020
Merged
[Python] Fix list element sorting in view, add QJsonModel.clear#17dridk merged 2 commits intodridk:masterfrom
dridk merged 2 commits intodridk:masterfrom
Conversation
This also fixed the test.
Owner
|
Thanks ! Interesting feature would be to sort fields by clicking on header . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @dridk , this PR fix the list element sorting in Python implementation.
Previously the index has converted into string type, and the sorting result is not desirable, 👇🏼
After the change, this should be the expected result, 👇🏼
Also, I have added the
clearmethod which is being called in the test case, but not actually being implemented.Thanks :)