Skip to content

[runtime] Reduce contention on some top locks when running Roslyn.#4675

Merged
kumpera merged 3 commits intomono:masterfrom
kumpera:runtime-scalability-take1
Apr 12, 2017
Merged

[runtime] Reduce contention on some top locks when running Roslyn.#4675
kumpera merged 3 commits intomono:masterfrom
kumpera:runtime-scalability-take1

Conversation

@kumpera
Copy link
Contributor

@kumpera kumpera commented Apr 11, 2017

gclass_cache, typespec_cache and get_image_set all suffers from heavy contention when runnign Roslyn.

This makes the read side of those concurrent. It saves in the order of 100ms wallclock time from Roslyn.

We're now malloc bound.

@kumpera
Copy link
Contributor Author

kumpera commented Apr 11, 2017

@vargaz This PR includes only the heavy hitters from #4564

Given the current execution profile, I'm inclined to drop the rest of the changes from #4564 if this one is good.

@vargaz
Copy link
Contributor

vargaz commented Apr 12, 2017

Hopefully this is not going to lead to random races.

@kumpera kumpera merged commit c7dfe96 into mono:master Apr 12, 2017
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
[runtime] Reduce contention on some top locks when running Roslyn.

Commit migrated from mono/mono@c7dfe96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants