[resgen] Remove dependency on WinForms and use it in mobile profiles#4667
[resgen] Remove dependency on WinForms and use it in mobile profiles#4667akoeplinger merged 1 commit intomono:masterfrom
Conversation
ac8a4f5 to
b92edd3
Compare
mcs/class/Makefile
Outdated
There was a problem hiding this comment.
We could remove this, as resgen_dir from build/ should be used
There was a problem hiding this comment.
I don't think we can remove it as we wouldn't install the resgen from the build profile?
There was a problem hiding this comment.
no, but we can (probably already do) build resgen standard way in tools/
There was a problem hiding this comment.
you're right, I'll remove it.
mcs/class/Makefile
Outdated
There was a problem hiding this comment.
Adding resgen to the build profile (it needs a dependency here in case tools/ and class/ are built in parallel).
There was a problem hiding this comment.
same question what needs resgen/had dependency on it here?
There was a problem hiding this comment.
I think this may have just been a fallout from the other change that broke parallel build, I'll try removing it.
resgen.exe used to load WinForms via reflection which is a pretty large dependency. Instead we can just embed the few types that are used for reading/writing resx files directly into the app. Add System.Drawing.dll to the "build" profile so we can put resgen there as well and allow us to no longer rely on system resgen for mobile profiles like monotouch/monodroid.
b92edd3 to
9299e59
Compare
…4667) resgen.exe used to load WinForms via reflection which is a pretty large dependency. Instead we can just embed the few types that are used for reading/writing resx files directly into the app. Add System.Drawing.dll to the "build" profile so we can put resgen there as well and allow us to no longer rely on system resgen for mobile profiles like monotouch/monodroid. (cherry picked from commit 9635b9c)
resgen.exe used to load WinForms via reflection which is a pretty large dependency. Instead we can just embed the few types that are used for reading/writing resx files directly into the app.
Add System.Drawing.dll to the "build" profile so we can put resgen there as well and allow us to no longer rely on system resgen for mobile profiles like monotouch/monodroid.