[runtime] Fix C and LLVM atomics on ARM64 #3464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@vargaz does the LLVM bit look ok? |
Contributor
|
Yes. |
Contributor
Author
mono/utils/atomic.h
Outdated
Member
There was a problem hiding this comment.
Do we really need unique names for this variable ?
Contributor
There was a problem hiding this comment.
Given the var is scoped, I wonder the same. It's a style issue, though.
Contributor
Author
There was a problem hiding this comment.
Probably a bit overengineered. Will simplify before merging.
Contributor
|
LGTM Good catch on removing ia64 dead code and unifying gcc version numbering. There's the style issue that Vlad pointed out, but that doesn't invalidate this PR itself. |
added 4 commits
August 30, 2016 21:12
See the comment in atomic.h for details.
This is a workaround. It's needed for the same reason that we need the fix for Clang's atomic intrinsics in mono/utils/atomic.h.
All ia64 compilers have intrinsics that we use. Also, this ia64 code was very out of date (missing many functions we use now) so it wouldn't compile anyway.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
[runtime] Fix C and LLVM atomics on ARM64 Commit migrated from mono/mono@2db49df
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.