Enable tests previously failing due to missing array ctor.#20100
Merged
lateralusX merged 1 commit intomono:masterfrom Aug 18, 2020
Merged
Enable tests previously failing due to missing array ctor.#20100lateralusX merged 1 commit intomono:masterfrom
lateralusX merged 1 commit intomono:masterfrom
Conversation
5c20a28 to
7080390
Compare
a01dd87 to
42a2be1
Compare
Fix mono#19494 adds missing array ctor needed by several tests currently failing as described by dotnet/runtime#34068. This PR fixes an additional problem hit by the IL array tests using an lbound != 0. Current Mono codegen for Set/Get/Address array methods didn't adjust index with regards to lbound causing failures in several of the array tests. NOTE, this scenario should only be hit when directly calling Set/Get/Address using IL on an array with an lbound != 0. It shouldn't affect regular szarray's at all since that code paths should never be used and the codegen currently looks up the lbounds unconditionally in the array, so if that code path ever gets hit by a szarray, it will imdediate crash, so shouldn't be causing any performance impact on szarrays. There is also an additional check on the array type as well as an additional precaution, so only arrays of type MONO_TYPE_ARRAY, hitting codegen for Set/Get/Address array method calls will adjust index based on lbound. This PR fix the lbound index codegen for that specific code path and re-eanbles the tests currently listed in dotnet/runtime#34068.
42a2be1 to
60da945
Compare
Member
|
Failures in Linux WebAssembly and OSX x64 Android SDK seems unrelated to this PR and appears on several other PR's as well. |
lateralusX
approved these changes
Aug 18, 2020
imhameed
added a commit
to imhameed/mono
that referenced
this pull request
Nov 4, 2020
Partial backport of mono#20100. Also see: dotnet/runtime#35008 (comment)
imhameed
added a commit
that referenced
this pull request
Nov 6, 2020
Partial backport of #20100. Should fix #20533. Also see: dotnet/runtime#35008 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
!! This PR is a copy of dotnet/runtime#35008, please do not edit or review it in this repo !!
Do not automatically approve this PR:
* Consider how the changes affect configurations in this repo,
* Check effects on files that are not mirrored,
* Identify test cases that may be needed in this repo.
!! Merge the PR only after the original PR is merged !!
Fix #19494 adds missing array ctor needed by several tests currently failing as described by dotnet/runtime#34068.
This PR re-eanbles the tests currently listed in dotnet/runtime#34068.