Skip to content

[crashing] update s390x handling#20022

Closed
sharkcz wants to merge 1 commit intomono:masterfrom
sharkcz:s390-crashing
Closed

[crashing] update s390x handling#20022
sharkcz wants to merge 1 commit intomono:masterfrom
sharkcz:s390-crashing

Conversation

@sharkcz
Copy link
Contributor

@sharkcz sharkcz commented Jun 25, 2020

commit 7a0425e broke build on s390x after
changing the signature of mono_handle_native_crash().

commit 7a0425e broke build on s390x after
changing the signature of mono_handle_native_crash().
@sharkcz
Copy link
Contributor Author

sharkcz commented Jun 25, 2020

The actual build failure is

...
  CC       libmini_la-monovm.lo
  CC       libmini_la-mini-s390x.lo
  CC       libmini_la-exceptions-s390x.lo
exceptions-s390x.c: In function ‘mono_arch_unwind_frame’:
exceptions-s390x.c:507:13: warning: variable ‘address’ set but not used [-Wunused-but-set-variable]
  507 |   uintptr_t address;
      |             ^~~~~~~
exceptions-s390x.c: In function ‘altstack_handle_and_restore’:
exceptions-s390x.c:576:4: error: too few arguments to function ‘mono_handle_native_crash’
  576 |    mono_handle_native_crash (mono_get_signame (SIGSEGV), ctx, NULL);
      |    ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from exceptions-s390x.c:63:
mini.h:2522:10: note: declared here
 2522 | void     mono_handle_native_crash               (const char *signal, MonoContext *mctx, MONO_SIG_HANDLER_INFO_TYPE *siginfo, void *context);
      |          ^~~~~~~~~~~~~~~~~~~~~~~~
make[4]: *** [Makefile:2487: libmini_la-exceptions-s390x.lo] Error 1

@sharkcz
Copy link
Contributor Author

sharkcz commented Jun 26, 2020

CC @nealef

@nealef
Copy link
Contributor

nealef commented Jun 26, 2020

I'll take a look.

@nealef
Copy link
Contributor

nealef commented Jun 26, 2020

PR #20028 generated

monojenkins pushed a commit to monojenkins/runtime that referenced this pull request Jun 26, 2020
…ash() for s390x

* Fix exception-s390x so mono_handle_native_crash() is called according to the changes made in mono/mono#19973
* Make roslyn the default compiler for s390x
@vargaz vargaz closed this in 1d3e43e Jun 30, 2020
vargaz pushed a commit to dotnet/runtime that referenced this pull request Jun 30, 2020
…ash() for s390x (#38428)

* Fix exception-s390x so mono_handle_native_crash() is called according to the changes made in mono/mono#19973
* Make roslyn the default compiler for s390x

Co-authored-by: nealef <nealef@users.noreply.github.com>
kevinwkt pushed a commit to kevinwkt/runtimelab that referenced this pull request Jul 15, 2020
…ash() for s390x (#38428)

* Fix exception-s390x so mono_handle_native_crash() is called according to the changes made in mono/mono#19973
* Make roslyn the default compiler for s390x

Co-authored-by: nealef <nealef@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants