[debugger] Access invalid memory address using PointerValue Command. #18537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…interValue. The IDE can send an invalid address and it was crashing mono. Fixes mono#18191
lambdageek
reviewed
Jan 22, 2020
Member
lambdageek
left a comment
There was a problem hiding this comment.
- Interesting approach
- How often does the debugger send these pointer commands? Does it only happen for user expression evaluation, or also for every local variable in a frame or other things like that that can happen on every step?
- Usual convention is
exit(0)for success, and 1 for failure
Contributor
Author
The debugger send these pointer commands on every step if there is a pointer variable like Int32*, I assumed that this is not VERY used, do you disagree? |
Member
|
This is also related to #15612 |
lambdageek
reviewed
Jan 22, 2020
lambdageek
approved these changes
Jan 24, 2020
vargaz
reviewed
Jan 24, 2020
vargaz
reviewed
Jan 24, 2020
vargaz
approved these changes
Jan 24, 2020
lambdageek
reviewed
Jan 24, 2020
Co-Authored-By: Aleksey Kliger (λgeek) <akliger@gmail.com>
Contributor
Author
|
@monojenkins build failed |
1 similar comment
Member
|
@monojenkins build failed |
Contributor
Author
|
@monojenkins build Windows x64 FullAOT+LLVM |
Contributor
Author
|
@monojenkins build OS X x64 iOS SDK |
Contributor
Author
|
@monojenkins build Linux AArch64 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
thaystg
added a commit
to thaystg/debugger-libs
that referenced
this pull request
Jan 27, 2020
thaystg
added a commit
to mono/debugger-libs
that referenced
this pull request
Jan 28, 2020
UnityAlex
pushed a commit
to Unity-Technologies/mono
that referenced
this pull request
Aug 7, 2020
…ono#18537) * Validate the address that came from IDE using PointerValue. The IDE can send an invalid address and it was crashing mono. Fixes mono#18191 Fixes mono#15612 Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
UnityAlex
pushed a commit
to Unity-Technologies/mono
that referenced
this pull request
Aug 10, 2020
…ono#18537) * Validate the address that came from IDE using PointerValue. The IDE can send an invalid address and it was crashing mono. Fixes mono#18191 Fixes mono#15612 Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com> Wrap create_file_to_check_memory_address in #ifndef _MSC_VER check as it's only used in that scope.
dtomar-rythmos
pushed a commit
to Unity-Technologies/mono
that referenced
this pull request
Sep 14, 2020
…ono#18537) * Validate the address that came from IDE using PointerValue. The IDE can send an invalid address and it was crashing mono. Fixes mono#18191 Fixes mono#15612 Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com> Wrap create_file_to_check_memory_address in #ifndef _MSC_VER check as it's only used in that scope.
dtomar-rythmos
pushed a commit
to Unity-Technologies/mono
that referenced
this pull request
Sep 14, 2020
…ono#18537) * Validate the address that came from IDE using PointerValue. The IDE can send an invalid address and it was crashing mono. Fixes mono#18191 Fixes mono#15612 Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com> Wrap create_file_to_check_memory_address in #ifndef _MSC_VER check as it's only used in that scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a fork process to access address that came from IDE using PointerValue. The IDE can send an invalid address and it was crashing mono.
Fixes #18191