Remove DNS lookups of the local hostname in tests#18059
Merged
akoeplinger merged 1 commit intomono:masterfrom Dec 5, 2019
Merged
Remove DNS lookups of the local hostname in tests#18059akoeplinger merged 1 commit intomono:masterfrom
akoeplinger merged 1 commit intomono:masterfrom
Conversation
This allows us to workaround issues we currently have in the macOS bot network where DNS lookup of the hostname fails.
Contributor
|
@monojenkins build failed |
steveisok
approved these changes
Dec 5, 2019
akoeplinger
added a commit
that referenced
this pull request
Dec 5, 2019
This allows us to workaround issues we currently have in the macOS bot network where DNS lookup of the hostname fails. (cherry picked from commit 269d509)
akoeplinger
added a commit
that referenced
this pull request
Dec 5, 2019
This allows us to workaround issues we currently have in the macOS bot network where DNS lookup of the hostname fails. (cherry picked from commit 269d509)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to workaround issues we currently have in the macOS bot network where DNS lookup of the hostname fails. We instead bind to 127.0.0.1.
All changes are in test code except for Mono.Messaging.RabbitMQ which used the local IP to generate a transaction ID. This doesn't seem necessary so replaced it with a GUID.