[profiler] disable inlining when coverage profiler is used and fix allocation sizes#17986
Merged
lewurm merged 2 commits intomono:masterfrom Dec 2, 2019
Merged
[profiler] disable inlining when coverage profiler is used and fix allocation sizes#17986lewurm merged 2 commits intomono:masterfrom
lewurm merged 2 commits intomono:masterfrom
Conversation
vargaz
approved these changes
Dec 2, 2019
Member
|
@monojenkins backport 2019-10 |
Contributor
|
Is this check not enough? Line 3958 in aa2fbc5 |
Contributor
Author
This check is about the inlinee. Let's assume that the caller has coverage instrumentation enabled and the callee (inlinee) has not, then, when inlining the callee, We probably could make it work by storing/restoring |
Member
|
@monojenkins backport 2019-12 |
Therzok
approved these changes
Dec 2, 2019
ManickaP
pushed a commit
to ManickaP/runtime
that referenced
this pull request
Jan 20, 2020
…location sizes (mono/mono#17986) * [profiler] let compiler decide about the size of an entry * [profiler] disable inlining when coverage profiler is used Commit migrated from mono/mono@a9a0a1e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17774