[corlib]: Move sre dependency into their own method in System.RuntimeType.#14698
Merged
marek-safar merged 7 commits intomono:masterfrom May 30, 2019
Merged
[corlib]: Move sre dependency into their own method in System.RuntimeType.#14698marek-safar merged 7 commits intomono:masterfrom
System.RuntimeType.#14698marek-safar merged 7 commits intomono:masterfrom
Conversation
…eType`. Move call to `TypeBuilderInstantiation.MakeGenericType` into a new `System.RuntimeType.MakeTypeBuilderInstantiation` method to allow the linker to remove it. Requires linker PR dotnet/linker#590.
lambdageek
approved these changes
May 29, 2019
lewing
approved these changes
May 29, 2019
Contributor
Author
|
@monojenkins build failed |
added 2 commits
May 29, 2019 17:44
Contributor
Author
|
@monojenkins build failed |
Contributor
Author
|
@monojenkins build Linux AArch64 |
marek-safar
approved these changes
May 30, 2019
Member
|
@monojenkins commit csproj and apidiff |
monojenkins
added a commit
to mono/api-snapshot
that referenced
this pull request
May 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move call to
TypeBuilderInstantiation.MakeGenericTypeinto a newSystem.RuntimeType.MakeTypeBuilderInstantiationmethod to allow thelinker to remove it.
Requires linker PR dotnet/linker#590.