[crash] Support extra merp params#12126
Merged
alexanderkyte merged 1 commit intomono:masterfrom Jan 2, 2019
Merged
Conversation
lambdageek
reviewed
Dec 19, 2018
mono/utils/mono-merp.c
Outdated
Member
There was a problem hiding this comment.
How many annotations are you expecting? This is an O(n) insertion. Could use a GQueue to get constant-time appends.
Contributor
Author
There was a problem hiding this comment.
Good catch. I think I'll just prepend to an slist.
Contributor
Author
There was a problem hiding this comment.
A queue to me implies that we care about the FIFO behavior. This is going to be immutable after it's installed.
f4a70c5 to
85ad77b
Compare
lambdageek
approved these changes
Dec 19, 2018
Contributor
Author
|
@monojenkins build deb with monolite |
Contributor
Author
|
@monojenkins build failed |
85ad77b to
c2438b7
Compare
Contributor
Author
|
Ah, corlib version was bumped. |
Contributor
Author
|
@monojenkins build deb with monolite |
Contributor
Author
|
@monojenkins build failed |
1 similar comment
Contributor
Author
|
@monojenkins build failed |
This was referenced Jan 7, 2019
Contributor
|
@monojenkins backport to 2018-08 |
Contributor
|
@luhenry backporting to 2018-10 failed, the patch results in conflicts: Please backport manually! |
Contributor
|
@luhenry backporting to 2018-08 failed, the patch results in conflicts: Please backport manually! |
Contributor
|
@luhenry backporting to 2018-12 failed, the patch results in conflicts: Please backport manually! |
This was referenced Jan 22, 2019
marek-safar
pushed a commit
that referenced
this pull request
Jan 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11579