This repository was archived by the owner on Aug 8, 2024. It is now read-only.
HttpClient.SendAsync() should not attempt to read response body on a HEAD request. #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HEAD or PUT request. (dotnet#38129) * HttpClient.SendAsync() should not attempt to read response body on a HEAD or PUT request. * Update HttpMethod.cs * Address feedback. * Cleanup. * Update HttpRequestMessageTest.cs (cherry picked from commit 73e610f)
kg
suggested changes
Jun 5, 2019
Member
kg
left a comment
There was a problem hiding this comment.
The description says HEAD or PUT but the code only seems to check for HEAD. I'm fine with it being as-is but I want to make sure they match since the description of the PR sounds like what we actually want...
kg
approved these changes
Jun 5, 2019
Member
|
@monojenkins backport to mono-2019-02 |
baulig
pushed a commit
to baulig/mono
that referenced
this pull request
Jun 5, 2019
HttpClient.SendAsync() should not attempt to read response body on a HEAD request. * CoreFX PR dotnet/corefx#38129. * Backported in mono/corefx#297. * Fixes mono#14214.
steveisok
pushed a commit
to mono/mono
that referenced
this pull request
Jun 6, 2019
HttpClient.SendAsync() should not attempt to read response body on a HEAD request. * CoreFX PR dotnet/corefx#38129. * Backported in mono/corefx#297. * Fixes #14214.
monojenkins
pushed a commit
to monojenkins/mono
that referenced
this pull request
Jun 6, 2019
HttpClient.SendAsync() should not attempt to read response body on a HEAD request. * CoreFX PR dotnet/corefx#38129. * Backported in mono/corefx#297. * Fixes mono#14214.
baulig
pushed a commit
to baulig/mono
that referenced
this pull request
Jun 6, 2019
HttpClient.SendAsync() should not attempt to read response body on a HEAD request. * CoreFX PR dotnet/corefx#38129. * Backported in mono/corefx#297. * Fixes mono#14214. (cherry picked from commit 2b3a23c)
marek-safar
pushed a commit
to mono/mono
that referenced
this pull request
Jun 6, 2019
HttpClient.SendAsync() should not attempt to read response body on a HEAD request. * CoreFX PR dotnet/corefx#38129. * Backported in mono/corefx#297. * Fixes #14214. (cherry picked from commit 2b3a23c)
marek-safar
pushed a commit
to mono/mono
that referenced
this pull request
Jun 6, 2019
HttpClient.SendAsync() should not attempt to read response body on a HEAD request. * CoreFX PR dotnet/corefx#38129. * Backported in mono/corefx#297. * Fixes #14214.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of dotnet#38129.
(cherry picked from commit 73e610f)
The description of the upstream PR mentions "HEAD and PUT request" - this was my original approach, which was discussed during code review and then changed into only doing it for HEAD. Thanks a lot to @kg for pointing this out.