Skip to content

Update Uno Platform to v3.0 #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattleibow merged 21 commits into from
Oct 1, 2020
Merged

Update Uno Platform to v3.0 #1489

mattleibow merged 21 commits into from
Oct 1, 2020

Conversation

@mattleibow
Copy link
Contributor

@mattleibow mattleibow commented Sep 3, 2020

Description of Change

  • Pull in the changes from Uno
  • Create a local branch so more things run
  • Add the new projects to all the solutions

Bugs Fixed

API Changes

Behavioral Changes

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation

@mattleibow mattleibow self-assigned this Sep 3, 2020
@mattleibow mattleibow mentioned this pull request Sep 3, 2020
Closed
4 tasks
@jeromelaban
Copy link
Contributor

jeromelaban commented Sep 10, 2020

@mattleibow what's failing in the CI, can I help ?

@mattleibow
Copy link
Contributor Author

mattleibow commented Sep 10, 2020

@jeromelaban ah, sorry about the delay. It is all good, just that CI can't build for iOS for a PR because it doesn't have access to the secrets.

I miss my public CI...

Anyway, I'll be merging soon. I just had to get out release signing working again. We have to make sure all the bits tick all the corporate boxes 😉

Thanks for the PR, it all looks good.

@jeromelaban
Copy link
Contributor

jeromelaban commented Sep 10, 2020

@mattleibow sweet ;) Thanks for the troubleshooting!

mattleibow
mattleibow commented Sep 10, 2020
View reviewed changes
Copy link
Contributor Author

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeromelaban I think all is good, I just want to confirm all the version numbers...

@jeromelaban
Copy link
Contributor

jeromelaban commented Sep 11, 2020

For python, I changed it this way: https://github.com/unoplatform/docker/blob/394e55f5b3571466c2377e6ec50bb13a4f77bec8/wasm-build/Dockerfile#L7

It changes the default python to 3.x

@mattleibow
Copy link
Contributor Author

mattleibow commented Sep 11, 2020

Very interesting... I didn't know about that.

But, I need v2 for gn. So this seems to work for now.

@mattleibow mattleibow marked this pull request as ready for review September 30, 2020 01:09
@mattleibow mattleibow merged commit 74a31ac into master Oct 1, 2020
@mattleibow mattleibow deleted the dev/uno-v3 branch October 1, 2020 15:56
@MartinZikmund MartinZikmund mentioned this pull request Oct 10, 2020
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jeromelaban jeromelaban jeromelaban left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mattleibow mattleibow

Labels

area/SkiaSharp.Views.Uno

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattleibow @jeromelaban