Skip to content

feat: Add support for Uno Platform 3.0 #1487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jeromelaban wants to merge 1 commit into from
Closed

feat: Add support for Uno Platform 3.0 #1487

jeromelaban wants to merge 1 commit into from

Conversation

@jeromelaban
Copy link
Contributor

@jeromelaban jeromelaban commented Sep 2, 2020

Description of Change

Updates to Uno Platform 3.0

Bugs Fixed

  • Fixes the WebAssembly SKXamlCanvas not being cleared on creation.

API Changes

None.

Behavioral Changes

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation

@ghost
Copy link

ghost commented Sep 2, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@jeromelaban jeromelaban force-pushed the dev/jela/uno3-origin2 branch from 48700cc to 2742a79 Compare September 2, 2020 03:19
@jeromelaban jeromelaban marked this pull request as ready for review September 2, 2020 03:25
@mattleibow
Copy link
Contributor

mattleibow commented Sep 2, 2020

Very nice! Thanks!

What is the reason for switching from the Marshal to the managed array? I have no problem just wondering the reason.

@jeromelaban
Copy link
Contributor Author

jeromelaban commented Sep 2, 2020

Very nice! Thanks!

What is the reason for switching from the Marshal to the managed array? I have no problem just wondering the reason.

This is for two reasons. The first is because the array needs to be memset to zero, and the second is looping in managed code can be quite slow with the interpreter, even when using pointers. Pinning the managed array and providing it to Skia is very fast.

Also the build is failing, but I cannot see the errors. What are they ?

@mattleibow
Copy link
Contributor

mattleibow commented Sep 3, 2020

Also the build is failing, but I cannot see the errors. What are they ?

Oh, nothing special... just the bot losing connection to the internet 😆 Nothing weird for a cloud machine. One might think these are real physical servers 🤔

@mattleibow mattleibow mentioned this pull request Sep 3, 2020
Merged
4 tasks
@mattleibow
Copy link
Contributor

mattleibow commented Sep 3, 2020 •
edited
Loading

@jeromelaban thanks for this PR!

I have merged it into a local branch (#1489) so that CI gets more power 😄
Things are looking good and it should be all good to merge into master when CI finishes.

@mattleibow mattleibow closed this Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/SkiaSharp.Views.Uno

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeromelaban @mattleibow